Skip to content

Conversation

@pokornyd
Copy link
Member

Motivation

Fixes #265

Adds missing ToDynamic implementations for IEnumerable<Reference> values and for AssetWithRenditionReference. Fixes incorrect FromDynamic implementations on BaseElement and adds round trip tests element → dynamic → element

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@pokornyd pokornyd requested a review from a team as a code owner June 11, 2025 11:34
@codecov
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

Attention: Patch coverage is 73.77049% with 16 lines in your changes missing coverage. Please review.

Project coverage is 84.13%. Comparing base (735db03) to head (39a3f81).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...ment/Models/Shared/AssetWithRenditionsReference.cs 68.29% 7 Missing and 6 partials ⚠️
...ent.Ai.Management/Modules/HttpClient/HttpClient.cs 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   84.48%   84.13%   -0.36%     
==========================================
  Files         288      288              
  Lines        2933     2975      +42     
  Branches      233      242       +9     
==========================================
+ Hits         2478     2503      +25     
- Misses        365      374       +9     
- Partials       90       98       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pokornyd pokornyd force-pushed the 265-ienumerable-dynamic-conversion branch 3 times, most recently from b35a4e4 to cbc382b Compare June 11, 2025 13:17
@pokornyd pokornyd force-pushed the 265-ienumerable-dynamic-conversion branch from cbc382b to cc2149c Compare June 11, 2025 13:22
@pokornyd pokornyd self-assigned this Jun 11, 2025
@pokornyd pokornyd requested a review from winklertomas June 12, 2025 07:25
@pokornyd pokornyd merged commit 89cbca2 into master Jun 12, 2025
5 checks passed
@pokornyd pokornyd deleted the 265-ienumerable-dynamic-conversion branch June 12, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FromDynamic on TaxonomyElement produces RuntimeBinderException on Value

3 participants