Skip to content

EN-599 Rename completion status completed to ready #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2025
Merged

EN-599 Rename completion status completed to ready #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Kontent.Ai.Management.Tests/ManagementClientTests/VariantFilterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ public async Task FilterVariantsAsync_WithValidRequest_ReturnsVariantFilterListi
{
Reference.ByCodename("article")
},
CompletionStatuses = new List<VariantFilterCompletionStatus> { VariantFilterCompletionStatus.Completed }
CompletionStatuses = new List<VariantFilterCompletionStatus> { VariantFilterCompletionStatus.Ready }
},
Order = new VariantFilterOrderModel
{
Expand Down Expand Up @@ -106,7 +106,7 @@ public async Task FilterVariantsAsync_WithComplexFilters_ReturnsVariantFilterLis
{
UserIdentifier.ByEmail("[email protected]")
},
CompletionStatuses = new List<VariantFilterCompletionStatus> { VariantFilterCompletionStatus.Completed, VariantFilterCompletionStatus.Unfinished },
CompletionStatuses = new List<VariantFilterCompletionStatus> { VariantFilterCompletionStatus.Ready, VariantFilterCompletionStatus.Unfinished },
WorkflowSteps = new List<VariantFilterWorkflowStepsModel>
{
new VariantFilterWorkflowStepsModel
Expand Down Expand Up @@ -249,7 +249,7 @@ public async Task FilterVariantsAsync_WithEnums_UsesCorrectValues()
Language = Reference.ByCodename("en-US"),
CompletionStatuses = new List<VariantFilterCompletionStatus>
{
VariantFilterCompletionStatus.Completed,
VariantFilterCompletionStatus.Ready,
VariantFilterCompletionStatus.Unfinished,
VariantFilterCompletionStatus.NotTranslated,
VariantFilterCompletionStatus.AllDone
Expand Down
6 changes: 3 additions & 3 deletions Kontent.Ai.Management/Models/VariantFilter/VariantFilterCompletionStatus.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,10 @@ public enum VariantFilterCompletionStatus
Unfinished,

/// <summary>
/// The variant is completed.
/// The variant is ready.
/// </summary>
[EnumMember(Value = "completed")]
Completed,
[EnumMember(Value = "ready")]
Ready,

/// <summary>
/// The variant is not translated.
Expand Down
Loading