-
Couldn't load subscription status.
- Fork 19
Upgrade packages & .Net version #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Rename ProjectId to EnvironmentId
|
hello Vincent, thank you very much for your submission. allow me to review the code and get back to you with updates |
test/Kontent.Ai.ModelGenerator.Tests/Options/ArgHelpersTests.cs
Outdated
Show resolved
Hide resolved
test/Kontent.Ai.ModelGenerator.Tests/Options/ArgHelpersTests.cs
Outdated
Show resolved
Hide resolved
|
thank you for your remarks. I took the liberty of further refactoring the code and replacing old references to |
Your welcome, and indeed saw that you reverted some things. Thank you for further picking up the work, looking to forward to update the tool soon :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I further simplified some leftover legacy initializations.
Since this will be a breaking change, I went through the other submitted issues to see if we could include in in this release, though I'll need a clarification on those from our development. it appears some of the issues may no longer be relevant.
either way, I'd be creating a separate PR for those. feel free to go through my changes and let me know if you have any remarks, otherwise, we can merge this
|
@pokornyd I would say, lets merge :) |
|
Hello again @vincent-aviva. I merged the changes only to discover we have an intermittent issue with one of the tests. specifically, |
Motivation
#193 Updated the .Net versions to .Net 8 because .net 6 is out of support
Updated the packages to use the latest, the only exeption is FluentAssertions because starting of version 8 you need to have a license. Therefore i set it to not use version 8 by setting the version to [7.2.0,8.0.0).
#194 With the update of the packages, also the Kontent packages where updated and these contained the change from ProjectId to EnvironmentId.
For the commandline i took the liberty of adding the -i (from id) as an argument because -e was already in use.
Checklist
How to test
If manual testing is required, what are the steps?