Implement personalization custom app example - #1
Closed
JiriLojda wants to merge 36 commits into
Closed
Conversation
IvanKiral
requested changes
Jan 21, 2026
- Change package name to @kontent-ai/personalization-custom-app - Remove useDefineForClassFields (unnecessary for functional code, default in ES2022)
- Simplify environment variables section (details in .env.example) - Remove redundant "Available Scripts" section
- Remove "Project structure" section (unnecessary) - Simplify env vars section (details in .env.template) - Use GitHub's [!WARNING] callout notation - Remove redundant "Scripts" section
- Use non-react config for netlify/functions directory - Add example-client to linting configuration - Fix react/jsx-no-constructed-context-values error with useMemo
- Use const arrays instead of Sets for codename lists - Add missing await to sync-content.ts main() call
- Create src/utils/taxonomy-utils.ts with shared utilities - Export TaxonomyTerm type and findVariantTermId function - Export flattenTaxonomyTerms function - Update hooks to import from shared utilities - Standardize on checkIsVariant naming (was checkIfVariant in useCurrentItem)
- Rename getManagementClient to createManagementClient - Move jsonResponse and errorResponse to response-utils.ts - Update all Netlify functions to use new imports
- Add comment explaining tryCreateNewVersion before deletion in delete-item.ts - Use type guard instead of cast in fetch-content-type.ts - Use .then() for cleaner snippet fetching in fetch-content-type.ts - Move request parsing outside try block in update-content-variants.ts
- Add @kontent-ai/model-generator dependency with generate:types script - Remove redundant !! boolean coercions in App.tsx - Use ReadonlyArray pattern with functional approach in kontentClient.ts - Remove redundant comments from variantResolver.ts - Move VALID_AUDIENCES to content.ts (derived from AUDIENCES)
- Rename otherVariants to linkedVariants for clarity - Rename fetchOtherVariantsData to fetchLinkedVariantsData - Update all references in types, utils, and components
Rename biome.json to biome.jsonc and disable the noExtraBooleanCast rule with a TODO comment linking to biomejs/biome#8664
IvanKiral
self-requested a review
January 26, 2026 08:03
IvanKiral
approved these changes
Jan 26, 2026
Member
Author
|
Closing since this PR only served for discussion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #
issue numberIf no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?