Release 2.0.0 #57
Release 2.0.0 #57
Conversation
pokornyd
force-pushed
the
vNext
branch
5 times, most recently
from
3ff3952 to
fdf4711
Compare
pokornyd
force-pushed
the
vNext
branch
3 times, most recently
from
4b976fc to
bb83273
Compare
tests/transfomers/portable-text-transformer/mapi-transformer.spec.ts
Outdated
Show resolved
Hide resolved
pokornyd
force-pushed
the
vNext
branch
2 times, most recently
from
7f66ffa to
97adf07
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57 +/- ##
==========================================
- Coverage 94.79% 88.80% -5.99%
==========================================
Files 19 22 +3
Lines 365 420 +55
Branches 68 85 +17
==========================================
+ Hits 346 373 +27
- Misses 19 47 +28 ☔ View full report in Codecov by Sentry. |
| _type: "componentOrItem", | ||
| _key: "guid", | ||
| component: { | ||
| _ref: "linkedItemOrComponentCodename", |
There was a problem hiding this comment.
@pokornyd , Would it be possible to change the _ref and _key in various objects with the expected value? I.e. in this case you assign a codename, but when using this I have no way of knowing if it's a codename/id or something else entirely.
If these properties are necessary for some reason and can't be renamed, I think it would be worth adding new custom properties that will represent the ID/codename appropriately.
There was a problem hiding this comment.
hey @Enngage. this had already been done. the underlying Reference type now also contains a referenceType string literal, with value of codename, external-id or id, informing you of the nature of the value stored in _ref.
the showcase is updated to reflect that, but the readme embed points to main branch version of it. should get sorted after the merge :)
| types: { | ||
| image: ({ value }: PortableTextComponentProps<PortableTextImage>) => resolveImage(value, h, toVueImageDefault), | ||
| image: ({ value }: PortableTextComponentProps<PortableTextImage>) => resolveImage(value, h), | ||
| table: ({ value }: PortableTextComponentProps<PortableTextTable>) => resolveTable(value, h, toPlainText), |
There was a problem hiding this comment.
@pokornyd not sure if this was changed, but when testing it I noticed that all properties under types were required - meaning you had to provide some sort of implementation even if you only needed to provide a resolver for image. Can these props be made optional instead?
There was a problem hiding this comment.
the helper types (PortableTextHtmlResolvers, PortableTextReactResolvers) are both set to be partial. I didn't create helper type for Vue, but PortableTextComponents["types"] appears to be partial by default
src/utils/transformer-utils.ts
Outdated
| (child: T) => traversePortableText(child, callback), | ||
| ); | ||
| } | ||
| export const traversePortableText = < |
There was a problem hiding this comment.
nitpick: formatting of generic can be onelined
| import { DomHtmlNode, DomNode } from "../../parser/parser-models.js"; | ||
|
|
||
| export type NodeToHtml<TContext = unknown> = ( | ||
| node: DomHtmlNode<any>, |
There was a problem hiding this comment.
can't this be node: DomHtmlNode<unknown>?
Motivation
Checklist
How to test
If manual testing is required, what are the steps?