-
Notifications
You must be signed in to change notification settings - Fork 8
Update next #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update next #64
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for new-sample-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Nice work, converting it also to app router @IvanKiral ! Will look into this for sure. |
|
@robfuncken Glad you like it! You mean you are also rewriting this app to app router? :) |
app/api/preview/route.ts
Outdated
|
|
||
| // TODO move secret to env variables | ||
| if (secret !== 'mySuperSecret' || !slug || !type) { | ||
| // res.status(401).json({ message: 'Invalid preview token, or no slug and type provided.' }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this if it is no longer needed.
| const SmartlinkInitializer: FC = () => { | ||
| useSmartLink(); | ||
|
|
||
| return <></>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you just return null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to be working
Motivation
Which issue does this fix? Fixes #
issue numberIf no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?