Skip to content

Conversation

@IvanKiral
Copy link
Contributor

Motivation

Which issue does this fix? Fixes #issue number

If no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?

Checklist

  • Code follows coding conventions held in this repo
  • Automated tests have been added
  • Tests are passing
  • Docs have been updated (if applicable)
  • Temporary settings (e.g. variables used during development and testing) have been reverted to defaults

How to test

If manual testing is required, what are the steps?

@IvanKiral IvanKiral requested a review from a team as a code owner January 15, 2025 12:36
@vercel
Copy link

vercel bot commented Jan 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ficto-healthtech ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 9:20am
ficto-healthtech-qa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 9:20am
ficto-imaging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 9:20am
ficto-imaging-qa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 9:20am
ficto-surgical ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 9:20am
ficto-surgical-qa ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 9:20am

@netlify
Copy link

netlify bot commented Jan 15, 2025

Deploy Preview for new-sample-app ready!

Name Link
🔨 Latest commit 6e3bebd
🔍 Latest deploy log https://app.netlify.com/sites/new-sample-app/deploys/678f6594265ce00008a1d67c
😎 Deploy Preview https://deploy-preview-64--new-sample-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@robfuncken
Copy link

Nice work, converting it also to app router @IvanKiral ! Will look into this for sure.

@IvanKiral
Copy link
Contributor Author

@robfuncken Glad you like it! You mean you are also rewriting this app to app router? :)


// TODO move secret to env variables
if (secret !== 'mySuperSecret' || !slug || !type) {
// res.status(401).json({ message: 'Invalid preview token, or no slug and type provided.' });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this if it is no longer needed.

const SmartlinkInitializer: FC = () => {
useSmartLink();

return <></>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you just return null?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants