DEVREL-1253 Update next and rewrite to app router #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update to new next version * update to new next * update api route to route handlers * add dev:https script to package.json * update homepage page to app router * rewrite [slug] page into app router * rewrite articles listing page * rewrite articles [slug] to app router * update products listing page to app router * rewrite produicts detail page to app router * rewrite solutions page to app router * update callback and getPreviewApiKey to app router, remove pages router * use new searchParam util in product listing * use notFound instead of throwing when siteMenu can not be found * remove unused funcitons, rewrite homepage route to use draft mode * temporarily change to default eslint * adjust readme * remove unnecesray comment * return null instead react fragment in smartlinkinitailzer
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for new-sample-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
IvanKiral
force-pushed
the
update-next
branch
from
8a76033 to
2f4246f
Compare
IvanKiral
force-pushed
the
update-next
branch
from
2f4246f to
b156855
Compare
JiriLojda
approved these changes
Jan 27, 2025
app/[envId]/products/page.tsx
Outdated
| }; | ||
|
|
||
|
|
||
| export const generateStaticParams = () => [ { envId: defaultEnvId } ] |
There was a problem hiding this comment.
How come that the envId param is not needed?
There was a problem hiding this comment.
because we are generating it in layout.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to new next version
update to new next
update api route to route handlers
add dev:https script to package.json
update homepage page to app router
rewrite [slug] page into app router
rewrite articles listing page
rewrite articles [slug] to app router
update products listing page to app router
rewrite produicts detail page to app router
rewrite solutions page to app router
update callback and getPreviewApiKey to app router, remove pages router
use new searchParam util in product listing
use notFound instead of throwing when siteMenu can not be found
remove unused funcitons, rewrite homepage route to use draft mode
temporarily change to default eslint
adjust readme
remove unnecesray comment
return null instead react fragment in smartlinkinitailzer
Motivation
Which issue does this fix? Fixes #
issue numberIf no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?