add action context to itemPreviewMessage #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanKiral
force-pushed
the
add-action-context
branch
from
bba6227 to
da0b48c
Compare
JiriLojda
approved these changes
Oct 16, 2025
| object_type: "content_item"; | ||
| delivery_slot: WebhookPreviewDeliverySlot; | ||
| } | ||
| & ({ |
There was a problem hiding this comment.
I would extract the union in the brackets just for readability's sake.
There was a problem hiding this comment.
Or even better, create a completely separate ContentItemWorkflowChangedPreviewMessage type similar to ContentItemPublishedMessage and use it in the union at the top.
There was a problem hiding this comment.
That would, of course, mean a breaking change considering all the types here are exported publicly through the chain of barrel exports 🙄 So maybe we can wait with this for the full modernisation and for now just extract the union out.
| delivery_slot: WebhookDeliverySlot; | ||
| }; | ||
|
|
||
| type ActionContext = { |
There was a problem hiding this comment.
I would choose a more specific name. Something like ItemWorkflowChangedActionContext?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Which issue does this fix? Fixes #
issue numberIf no issue exists, what is the fix or new feature? Were there any reasons to fix/implement things that are not obvious?
Checklist
How to test
If manual testing is required, what are the steps?