-
Notifications
You must be signed in to change notification settings - Fork 24
🧪 Add E2E tests for Welcome View in Konveyor sidebar #1225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
📝 WalkthroughWalkthroughAdds a new end-to-end test suite at tests/e2e/tests/base/welcome-view.test.ts. The suite launches a test VSCode instance with a sample repository, asserts visibility of the Welcome sidebar message and documentation text/link, verifies that the “Open Analysis Panel” and “Manage Profiles” links open their respective views and display expected content, uses timeouts up to 30s for visibility checks, and closes the test app in teardown. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
abrugaro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, some considerations:
- Try not to use explicit timeouts, they explicitely increase the test time and most of the times they're not needed
- Test PRs titles should start with 🧪 , not 🌱
- Try not to hardcode "konveyor", that won't work with other brandings
Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: Ran Wurmbrand <[email protected]>
911358f to
a8aebb6
Compare
Signed-off-by: Ran Wurmbrand <[email protected]>
a8aebb6 to
0c7039d
Compare
Summary
Test Coverage
Test Details
coolstoretest repository as the test fixture@tier3beforeAllandafterAllhooksSummary by CodeRabbit