Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tiny layout improvements #54

Merged
merged 8 commits into from
Mar 28, 2025

Conversation

thisisobate
Copy link
Contributor

fixes #52 #51

Copy link

netlify bot commented Mar 27, 2025

Deploy Preview for konveyor-docs ready!

Name Link
🔨 Latest commit 68c314c
🔍 Latest deploy log https://app.netlify.com/sites/konveyor-docs/deploys/67e6bcd2b47bc800082fe32d
😎 Deploy Preview https://deploy-preview-54--konveyor-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 27, 2025

Deploy Preview for glowing-cassata-a7b83f ready!

Name Link
🔨 Latest commit 68c314c
🔍 Latest deploy log https://app.netlify.com/sites/glowing-cassata-a7b83f/deploys/67e6bcd280090c00087884b7
😎 Deploy Preview https://deploy-preview-54--glowing-cassata-a7b83f.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@nate-double-u nate-double-u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JonathanR19
Copy link
Contributor

I took a look. That paragraph text in the header is still hard to read. Where as sub heading text is much easier to read on this web page (different website.)

Can a bit bigger and reduce line height to accommodate for this? Sorry for the tweaks. But it does affect legibility a lot.

Font size: 1.125 REM, 1.5 line height. We can try applying this to all paragraph text.

Feel free to suggest other solutions to make text legible.

@thisisobate
Copy link
Contributor Author

Fixed...feel free to take a look @JonathanR19

@JonathanR19 JonathanR19 merged commit b2e68f2 into konveyor:main Mar 28, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slightly increase paragraph text tag
3 participants