🐛 Fix oauth to work with external access networkpolicy #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Montleon <[email protected]>
|
/lgtm |
djzager
approved these changes
Mar 19, 2025
| @@ -152,7 +152,7 @@ oauth_provider: openshift | |||
| oauth_default_openshift_sar: --openshift-sar={"namespace":"{{ app_namespace }}","resource":"services","resourceName":"{{ ui_service_name }}","verb":"get"} | |||
| oauth_access_rule: "{{ oauth_default_openshift_sar if oauth_provider == 'openshift' }}" | |||
| oauth_image_fqin: "{{ lookup('env', 'RELATED_IMAGE_OAUTH_PROXY') }}" | |||
| oauth_ssl_port: 9443 | |||
| oauth_ssl_port: 8443 | |||
There was a problem hiding this comment.
I added a comment on the PR for main, apologies, I did not include it on this one:
The external access network policy allows 8080 and 8443. So using 8443 instead of 9443 allows everything to work.
I think my PR to add the oauth proxy predated the networkpolicy, so the auth proxy listening on 9443 at the time worked. That is no longer true as the traffic gets blocked. Alternatively I could have added port 9443 to the networkpolicy, but I went with this route.
There was a problem hiding this comment.
heh. I saw it and didn't connect them.
This was referenced Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.