Skip to content

Conversation

@jmle
Copy link
Contributor

@jmle jmle commented Nov 12, 2025

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration to add a new test reference parameter.

Note: This release contains internal infrastructure updates with no user-visible changes.

Signed-off-by: Juan Manuel Leflet Estrada <[email protected]>
@jmle jmle requested review from aufi, eemcmullan and jortel November 12, 2025 16:27
@jmle jmle added the cherry-pick/release-0.8 This PR should be cherry-picked to release-0.8 branch label Nov 12, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 12, 2025

Walkthrough

A new input parameter api_tests_ref is added to the test-integration job in the GitHub Actions workflow. This parameter is passed to the global CI bundle workflow alongside existing parameters tackle_hub and api_hub_tests_ref.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/main.yml
Added api_tests_ref input parameter to the test-integration job and passed it to the invoked global CI bundle workflow

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single parameter addition to a workflow configuration file with no logic changes
  • Minimal scope and straightforward, repetitive change pattern

Poem

🐰 A reference new joins the workflow's call,
api_tests_ref hops into the hall,
Alongside its friends it shall pass along,
To global CI bundles, steady and strong! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title correctly describes the main change: adding an api_tests_ref parameter to use the correct branch for tests in the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d804109 and b0d7a32.

📒 Files selected for processing (1)
  • .github/workflows/main.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: test-unit
  • GitHub Check: build
  • GitHub Check: vet
🔇 Additional comments (1)
.github/workflows/main.yml (1)

97-97: The new parameter addition looks good.

The change correctly adds api_tests_ref alongside the existing api_hub_tests_ref parameter, using the same ${{ github.ref }} context to ensure the correct branch reference is passed to the test workflow. This aligns with the PR objective.

To confirm this change is fully correct, please verify that:

  1. The konveyor/ci/.github/workflows/global-ci-bundle.yml@main workflow actually accepts api_tests_ref as an input parameter.
  2. The workflow has been tested and passes with this new parameter.

If you have access to the target workflow file and can confirm these points, this change is ready to merge.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jmle jmle added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2025
@aufi aufi closed this Dec 4, 2025
@aufi aufi reopened this Dec 4, 2025
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks CI is failing with this change.

  Error: fatal: couldn't find remote ref refs/pull/950/merge

@jmle jmle closed this Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick/release-0.8 This PR should be cherry-picked to release-0.8 branch do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants