Skip to content

fix(Button): correct disabled border color in outline variants (DS-5384) - #434

Merged
KamilEmeleev merged 1 commit into
mainfrom
fix/ds-5384
Jul 29, 2026
Merged

fix(Button): correct disabled border color in outline variants (DS-5384)#434
KamilEmeleev merged 1 commit into
mainfrom
fix/ds-5384

Conversation

@KamilEmeleev

@KamilEmeleev KamilEmeleev commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Style
    • Adjusted the styling order for disabled buttons to ensure disabled colors are applied consistently alongside theme-transparent variants.

@KamilEmeleev KamilEmeleev added the bug Something isn't working label Jul 29, 2026
@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 42945c7a-7787-4165-8c71-c8f189a364c1

📥 Commits

Reviewing files that changed from the base of the PR and between 5257abe and 14cdfdb.

📒 Files selected for processing (1)
  • packages/components/src/components/Button/Button.module.css

📝 Walkthrough

Walkthrough

The button stylesheet repositions the .disabled class block so its border, text, and background color declarations appear after the transparent theme variants.

Changes

Button styling

Layer / File(s) Summary
Disabled state style placement
packages/components/src/components/Button/Button.module.css
The .disabled declarations are placed immediately before .focusVisible, defining disabled border, text, and background colors.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the change intent: a Button CSS fix for disabled outline-variant styling.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ds-5384

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit 14cdfdb):

https://react-koobiq-next--prs-434-2ufdcteb.web.app

(expires Mon, 03 Aug 2026 14:35:59 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: fc29847d4a9e5cb1adf458c76a9b681c76e2eeff

@KamilEmeleev
KamilEmeleev merged commit 2c8ce2d into main Jul 29, 2026
8 checks passed
@KamilEmeleev
KamilEmeleev deleted the fix/ds-5384 branch July 29, 2026 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant