This repository was archived by the owner on Apr 17, 2024. It is now read-only.
KSD-389: add support for JWT Auth token#36
Open
Javlopez wants to merge 1 commit into
Open
Conversation
Javlopez
requested review from
aaron-at-koor,
dave-at-koor,
galexrt and
zalsader
galexrt
reviewed
Apr 16, 2024
| //debug | ||
| if claims, exists := c.Get("claims"); exists { | ||
| claims := claims.(*models.AuthJwtClaims) | ||
| fmt.Println("-----------------------") |
Member
There was a problem hiding this comment.
We should remove the print statements before the PR is merged or at least changing to log statements that they are in line with the other log outputs.
galexrt
approved these changes
Apr 16, 2024
galexrt
left a comment
galexrt
left a comment
Member
There was a problem hiding this comment.
Besides the print statements, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.