-
-
Notifications
You must be signed in to change notification settings - Fork 11
Add Recipe for WaveShare ESP32S3 Round 1.28" LCD with Touch #84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Recipe for WaveShare ESP32S3 Round 1.28" LCD with Touch #84
Conversation
|
Currently this recipe generates code with some dual sections. See the attached example with a circle and a simple Hello text. Also have issued with the designer to use the latest version from my branch. I forked the repo, created my own branch. Cloned that onto my Home Assistant. Each time after pushing a commit to that branch I do: Doing Here is the latest generated yaml when comparing to this PR it obviously misses the new substitutions like name: |
|
Thank you for putting work into this, can of course not pull as long as it is not working. |
|
Happy to help out and make your great work be even better! The link is provided in the TARGET DEVICE 😄 And here it is too https://www.waveshare.com/esp32-s3-touch-lcd-1.28.htm but do not put time into the device details. I'll sort that out but of course ask if you can get one 😄 I changed to v0.8.2B6 but kept my device file. It behaves the same. But noticed when I switch to the ones that do not have (untested) in their name the "Hardware Recipe / Package Content" section is not duplicated. But when I select any of the "untested" it is! Also noticed there and no files under frontend/hardware for the not-untested like M5Paper. Are they somehow different? Checked the code and they seems to be treated completely different and implemented in devices.js. How come? |
|
Thanks for the link and the kind words :-) Device.js is my "old" way how I implemented all the hardware Profils, it works very well but it will not work for the recipe idea. So I think the recipe mechanism is still buggy with all the dublicate problems, so I need to analyse this and fix it. Once it works I think all new hardware will be implemented this way, but one other downside is that unfortunately this will not work offline with file html :-/ |
WIP: Have some issues with the generated YAML