Skip to content

fix: Set Git attrs for untracked folder#204

Merged
tisonkun merged 5 commits intomainfrom
fixup-untrack-folder
Feb 7, 2026
Merged

fix: Set Git attrs for untracked folder#204
tisonkun merged 5 commits intomainfrom
fixup-untrack-folder

Conversation

@tisonkun
Copy link
Member

@tisonkun tisonkun commented Feb 6, 2026

This fixes #202.

@Lorilatschki You can test it out and I'd hold it for a few days to think once more.

Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Signed-off-by: tison <wander4096@gmail.com>
Comment on lines +206 to +213
let dirpath = gix::path::from_bstr(&entry.rela_path)
.canonicalize()
.with_context(|| {
format!("cannot resolve absolute path: {}", &entry.rela_path)
})?;

let mut it = WalkDir::new(dirpath).follow_links(false).into_iter();
while let Some(entry) = it.next() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to select_files_with_git. Perhaps some code share is possible. But I'd leave it later.

@Lorilatschki
Copy link
Contributor

Lorilatschki commented Feb 6, 2026

This fixes #202.

@Lorilatschki You can test it out and I'd hold it for a few days to think once more.

Installed the version from branch fixup-untrack-folder and for an untracked file in an untracked folder it works. I also verified, that it works for an untracked file, in an untracked folder below an untracked folder.

@tisonkun
Copy link
Member Author

tisonkun commented Feb 7, 2026

OK. I'll release a 6.4.2 for this fix.

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun enabled auto-merge (squash) February 7, 2026 05:44
@tisonkun tisonkun merged commit 8d6759b into main Feb 7, 2026
17 checks passed
@tisonkun tisonkun deleted the fixup-untrack-folder branch February 7, 2026 05:48
@tisonkun
Copy link
Member Author

tisonkun commented Feb 7, 2026

6.4.2 is now released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

attrs.git_file_created_year is not tracked, if parent folder is untracked

2 participants

Comments