Avoid use of dependsOn #174
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the Gradle build to replace the use of `processResources.dependsOn` with a proper dependency. The rationale is described here: https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html But in a nutshell: hooking the generation of the resources on the `processResources` task will only work if the `processResources` task is actually called, so it works "by accident" when you generate a jar for example. However, let's say that you have another task, in another plugin, which needs to reason about all available resources, including these generated by other plugins. In that case, that plugin would not see the native image source set. The fix is actually fairly straightforward: you need to declare that the task contributes to the `resources` source set, and Gradle will automatically handle the task dependencies when needed: result should never depend on the execution of lifecycle tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the Gradle build to replace the use of
processResources.dependsOnwith a proper dependency.The rationale is described here:
https://melix.github.io/blog/2021/10/gradle-quickie-dependson.html
But in a nutshell: hooking the generation of the resources on the
processResourcestask will only work if theprocessResourcestask is actually called, so it works "by accident" when you generate a jar for example. However, let's say that you have another task, in another plugin, which needs to reason about all available resources, including these generated by other plugins. In that case, that plugin would not see the native image source set.The fix is actually fairly straightforward: you need to declare that the task contributes to the
resourcessource set, and Gradle will automatically handle the task dependencies when needed: result should never depend on the execution of lifecycle tasks.