fix(mkmk2samples): iterate sources in samples based on mod source count #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostmod
commented
Dec 27, 2025
| for(int voice = 0; voice < ctxt->voiceLimit; voice+=4) | ||
| { | ||
| for(int modDest = 0; modDest < kNumModDest; modDest++) | ||
| for(int modDest = 0; modDest < kNumMk2ModSrc; modDest++) |
Contributor
Author
There was a problem hiding this comment.
on line 383 we're using the indexer variable on the variable dests, which is defined as such:
float * dests[kNumMk2ModSrc];
Also this sets implementers up for an interesting time if they are following this pattern and have a kNumModDest set as > 6
frostmod
commented
Dec 27, 2025
| for(int voice = 0; voice < ctxt->voiceLimit; voice+=4) | ||
| { | ||
| for(int modDest = 0; modDest < kNumModDest; modDest++) | ||
| for(int modDest = 0; modDest < kNumMk2ModSrc; modDest++) |
Contributor
Author
There was a problem hiding this comment.
kNumModDest here is 1, so this would effectively prohibit using mod slots 2-6 if I'm reading this right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes samples for Microkorg2 to iterating based on mod source count (6).
In vox and waves samples message kMk2PlatformExclusiveModData we're iterating the mod sources based on kNumModDest. That probably works for Vox because it has 6 mod destinations (same number as mod sources or slots), but in Waves that should cause only slot 1 to work (if I'm reading this right) as it has only 1 mod destination.
This could also cause some implementer grief when using more than 6 mod destinations - kNumMk2ModDest is defined as 10, I but couldn't find anything about number of allowed mod destinations