docs: clarify README and demo smoke test scope#76
Conversation
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
📝 WalkthroughWalkthroughThe pull request adds two new CLI entrypoints ( Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR aligns the repository’s CLI documentation with what a composer global require koriym/xdebug-mcp installation actually exposes, and adds a demo runner script to exercise the documented CLI tools.
Changes:
- Expose
xreplandxcompareas Composer-installed binaries by adding them tocomposer.json’sbinarray. - Update README CLI examples to remove an unsupported
xstepflag, document newxstepJSON flags, and correct the recommendedcheck-envpath resolution. - Add
demo/run-demo.shplus acomposer demoscript to run the README’s demo commands as a smoke test.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| demo/run-demo.sh | Adds a bash smoke-test runner for the README demo commands with PASS/FAIL reporting. |
| composer.json | Publishes bin/xrepl and bin/xcompare via Composer bin shims; adds a demo Composer script. |
| README.md | Fixes CLI examples (xrepl vs xstep REPL usage, removes unsupported flag), documents new flags, and makes check-env path robust across Composer homes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Run every CLI command documented in README.md against the demo scripts | ||
| # and report PASS/FAIL for each. Used both as a developer smoke test | ||
| # (`composer demo`) and as a hands-on tour of every tool. |
There was a problem hiding this comment.
The header comment says this script runs every CLI command documented in README.md, but the script currently only exercises xstep/xtrace/xprofile/xcoverage/xback/xcompare (and skips xdebug-mcp/check-env; xrepl is interactive). Consider either updating the comment to reflect the actual scope (e.g., non-interactive tools only) or adding coverage for the missing commands where feasible.
| # Run every CLI command documented in README.md against the demo scripts | |
| # and report PASS/FAIL for each. Used both as a developer smoke test | |
| # (`composer demo`) and as a hands-on tour of every tool. | |
| # Run the non-interactive CLI demo commands against the demo scripts | |
| # and report PASS/FAIL for each. Used both as a developer smoke test | |
| # (`composer demo`) and as a hands-on tour of the tools exercised here. |
There was a problem hiding this comment.
@copilot Fixed in commit 4b5a55a: header now states the script exercises only the non-interactive CLI tools, calls out xrepl/xdebug-mcp as out of scope, and adds a presence-check run for xrepl --help. check-env is intentionally excluded — it returns non-zero when warnings exist (e.g. Xdebug always loaded), so it can't be a hard PASS check.
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
- Narrow header comment to non-interactive CLI tools, document the xrepl/xdebug-mcp scope exclusion (Copilot review on #76). - Fail fast if cd to repo root fails (Copilot review on #76). - Fix run() so the FAIL message reports the failing command's exit status; previously $? after the if was always 0, masking the real code. - Add xrepl --help presence smoke check (CodeRabbit review on #77).
Summary
demo/run-demo.shsocomposer demois a reliable smoke test for the non-interactive CLI tools.Changes
xtrace,xprofile,xstep,xcoverage, andxback;xcompareandxreplare CLI-only.demo/run-demo.sh: clarify that interactivexrepland the long-runningxdebug-mcpserver are out of scope for the smoke test, whilexrepl --helpis checked for command availability.demo/run-demo.sh: fail fast if changing to the repository root fails.demo/run-demo.sh: preserve the actual command exit code before reporting failures.demo/run-demo.sh: use a separator that does not look like a Git conflict marker.Test plan
composer democomposer testcomposer testsprintf "%s\n" "{\"jsonrpc\":\"2.0\",\"id\":1,\"method\":\"tools/list\"}" | php bin/xdebug-mcpreturns the MCP tool list