Skip to content

docs: clarify README and demo smoke test scope#76

Merged
koriym merged 4 commits into
1.xfrom
readme-cli-discoverability
Apr 29, 2026
Merged

docs: clarify README and demo smoke test scope#76
koriym merged 4 commits into
1.xfrom
readme-cli-discoverability

Conversation

@koriym

@koriym koriym commented Apr 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • Clarify the README so the project positioning matches the current implementation: CLI is the primary interface, while MCP remains supported for the core one-shot analysis tools.
  • Tighten demo/run-demo.sh so composer demo is a reliable smoke test for the non-interactive CLI tools.

Changes

  • README: describe AI integrations through Claude Code plugin, Codex Skill, or MCP-capable clients.
  • README: document the MCP/CLI boundary explicitly. MCP exposes xtrace, xprofile, xstep, xcoverage, and xback; xcompare and xrepl are CLI-only.
  • demo/run-demo.sh: clarify that interactive xrepl and the long-running xdebug-mcp server are out of scope for the smoke test, while xrepl --help is checked for command availability.
  • demo/run-demo.sh: fail fast if changing to the repository root fails.
  • demo/run-demo.sh: preserve the actual command exit code before reporting failures.
  • demo/run-demo.sh: use a separator that does not look like a Git conflict marker.

Test plan

  • composer demo
  • composer test
  • composer tests
  • printf "%s\n" "{\"jsonrpc\":\"2.0\",\"id\":1,\"method\":\"tools/list\"}" | php bin/xdebug-mcp returns the MCP tool list

@koriym

koriym commented Apr 28, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

The pull request adds two new CLI entrypoints (xrepl and xcompare) to the Composer package configuration and updates README documentation examples to reflect current debugging workflows, including clarifications on tool usage and command options.

Changes

Cohort / File(s) Summary
Documentation
README.md
Updated CLI examples: check-env discovery via Composer bin-dir, removed --exit-on-break flag from xstep examples, added JSON output example with truncation, clarified xrepl as the interactive debugger and replaced REPL example accordingly.
Package Configuration
composer.json
Added bin/xrepl and bin/xcompare to the "bin" list to expose these commands as installable Composer executables.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

  • PR #3: Updates README documentation content and CLI examples; directly related to the documentation changes in this PR.
  • PR #71: Modifies bin/xcompare implementation and tests; related to exposing bin/xcompare as a new CLI entrypoint in this PR.
  • PR #38: Updates CLI surface by modifying README examples and the Composer bin list; related to the entrypoint configuration and documentation changes.

Suggested reviewers

  • sourcery-ai

Poem

🐰✨ Two new commands hop into view,
xrepl and xcompare—fresh paths to pursue!
The README now gleams with examples refined,
A debugger's delight, more clearly defined.
Composer knows well these companions so bright! 🎯

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title 'docs: clarify README and demo smoke test scope' is vague and does not accurately reflect the main changes, which include both README CLI example fixes and exposing new CLI commands via composer.json. Revise the title to something more specific like 'docs: fix README CLI examples and expose xrepl/xcompare via composer bin' to clearly convey the actual changes made.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch readme-cli-discoverability

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aligns the repository’s CLI documentation with what a composer global require koriym/xdebug-mcp installation actually exposes, and adds a demo runner script to exercise the documented CLI tools.

Changes:

  • Expose xrepl and xcompare as Composer-installed binaries by adding them to composer.json’s bin array.
  • Update README CLI examples to remove an unsupported xstep flag, document new xstep JSON flags, and correct the recommended check-env path resolution.
  • Add demo/run-demo.sh plus a composer demo script to run the README’s demo commands as a smoke test.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
demo/run-demo.sh Adds a bash smoke-test runner for the README demo commands with PASS/FAIL reporting.
composer.json Publishes bin/xrepl and bin/xcompare via Composer bin shims; adds a demo Composer script.
README.md Fixes CLI examples (xrepl vs xstep REPL usage, removes unsupported flag), documents new flags, and makes check-env path robust across Composer homes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread demo/run-demo.sh Outdated
Comment on lines +2 to +4
# Run every CLI command documented in README.md against the demo scripts
# and report PASS/FAIL for each. Used both as a developer smoke test
# (`composer demo`) and as a hands-on tour of every tool.

Copilot AI Apr 28, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The header comment says this script runs every CLI command documented in README.md, but the script currently only exercises xstep/xtrace/xprofile/xcoverage/xback/xcompare (and skips xdebug-mcp/check-env; xrepl is interactive). Consider either updating the comment to reflect the actual scope (e.g., non-interactive tools only) or adding coverage for the missing commands where feasible.

Suggested change
# Run every CLI command documented in README.md against the demo scripts
# and report PASS/FAIL for each. Used both as a developer smoke test
# (`composer demo`) and as a hands-on tour of every tool.
# Run the non-interactive CLI demo commands against the demo scripts
# and report PASS/FAIL for each. Used both as a developer smoke test
# (`composer demo`) and as a hands-on tour of the tools exercised here.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Fixed in commit 4b5a55a: header now states the script exercises only the non-interactive CLI tools, calls out xrepl/xdebug-mcp as out of scope, and adds a presence-check run for xrepl --help. check-env is intentionally excluded — it returns non-zero when warnings exist (e.g. Xdebug always loaded), so it can't be a hard PASS check.

Comment thread demo/run-demo.sh
@koriym

koriym commented Apr 28, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor
✅ Actions performed

Full review triggered.

- Narrow header comment to non-interactive CLI tools, document the
  xrepl/xdebug-mcp scope exclusion (Copilot review on #76).
- Fail fast if cd to repo root fails (Copilot review on #76).
- Fix run() so the FAIL message reports the failing command's exit
  status; previously $? after the if was always 0, masking the real
  code.
- Add xrepl --help presence smoke check (CodeRabbit review on #77).
@koriym koriym changed the title docs: fix README CLI examples and expose xrepl/xcompare via composer bin docs: clarify README and demo smoke test scope Apr 29, 2026
@koriym
koriym merged commit 7b5883a into 1.x Apr 29, 2026
7 checks passed
@koriym
koriym deleted the readme-cli-discoverability branch April 29, 2026 16:07
@koriym koriym mentioned this pull request Apr 29, 2026
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants