Fix fixed updater by removing anti-hiccups code #2323
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I write this code and count myself how much invocations are triggered per second I found that it is ~36
That happens because sometimes when
accum >= 0.75 * timewe subtracttimeand getting accum < 0 (meaning that we need to wait more next time) But then in the code I'm about to delete we just forgetting that fact.Maybe better way to fix it is by adding
&& accum > 0But I actually don't understand what hiccups mean here. And can't see problems which this code solves.