Skip to content

Updating onnx example to resize image to model input shape. #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kylekam
Copy link
Contributor

@kylekam kylekam commented Mar 22, 2025

Small PR. ONNX example currently doesn't work unless the image already matches the model input shape. Resizing allows any 3 channel image to be used.

Copy link
Member

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you actually tried ? you can use one of these models: https://huggingface.co/kornia/ONNX_models/tree/main/models

can you also update the readme in the example exaplaining how and where to download the model ot use

@kylekam
Copy link
Contributor Author

kylekam commented Mar 23, 2025

Have you actually tried ? you can use one of these models: https://huggingface.co/kornia/ONNX_models/tree/main/models

can you also update the readme in the example exaplaining how and where to download the model ot use

Ah okay, I didn't realize there was a huggingface location for the models. I confirmed this issue using RT-DETR from their official repo, but if the intended use case is to only use kornia models, then I can just update the readme and remove the other changes.

@edgarriba
Copy link
Member

did it work at all with theirs ? our version provides some pre/post processings

@kylekam
Copy link
Contributor Author

kylekam commented Mar 24, 2025

did it work at all with theirs ? our version provides some pre/post processings

Initially there was a shape mismatch, but adding the resizing seemed to fix the input issue. As for post processing, I think stuff like NMS needs to be implemented as well, so maybe it's best to recommend that people use the kornia models.

@kylekam
Copy link
Contributor Author

kylekam commented Mar 24, 2025

Reverted the changes, linked kornia ONNX, and updated the README for clarification.

Copy link
Member

@edgarriba edgarriba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge as soon as we fix the ci

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants