QR Code Detection Implementation and Add Tests #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #231
Summary
This PR implements proper QR code detection functionality in the
kornia-qr
crate using therqrr
library. It fixes build issues, adds proper tests, and ensures seamless integration with the main Kornia crate.Changes
1. Fixed API usage and version handling
rqrr
library API by simplifying the QR code version handling2. Added comprehensive testing
tests/data/qr/
3. Fixed build dependencies
kornia
dependency fromkornia-qr
Cargo.toml
to0.1.9-rc.2
to match the workspace4. Created example application
qr_detector
example inexamples/qr_detector/
Testing
These changes make the QR code detection functionality in Kornia more robust and user-friendly while ensuring proper integration with the rest of the Kornia ecosystem.