QR Code Detection Implementation and Add Tests #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
edgarriba
requested changes
May 13, 2025
| //! It uses the `rqrr` crate for actual QR decoding and integrates with | ||
| //! kornia's tensor operations for image processing. | ||
|
|
||
| use anyhow::Result; |
| /// | ||
| /// Returns an error if conversion, detection, or decoding fails. | ||
| pub fn detect_and_decode( | ||
| image: &Tensor<u8, 3, CpuAllocator>, |
There was a problem hiding this comment.
use directly Image<u8, 3> to avoid the conversion
| let grayscale = Self::tensor_to_grayscale(image)?; | ||
|
|
||
| // Prepare the image for QR detection | ||
| let mut prepared = PreparedImage::prepare(grayscale.clone()); |
| //! kornia's tensor operations for image processing. | ||
|
|
||
| use anyhow::Result; | ||
| use image::{GrayImage, ImageBuffer}; |
|
|
||
| // Include the tests module | ||
| #[cfg(test)] | ||
| mod tests; |
There was a problem hiding this comment.
add this tests here to be more compact
|
|
||
| impl QrDetectionExt<u8, 1> for Image<u8, 1> { | ||
| fn detect_qr_codes(&self) -> Result<Vec<QrDetection>, QrError> { | ||
| // First convert grayscale image to a 3-channel tensor |
There was a problem hiding this comment.
use rgb_from_gray from here https://github.com/kornia/kornia-rs/blob/main/crates/kornia-imgproc/src/color/gray.rs#L134
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #231
Summary
This PR implements proper QR code detection functionality in the
kornia-qrcrate using therqrrlibrary. It fixes build issues, adds proper tests, and ensures seamless integration with the main Kornia crate.Changes
1. Fixed API usage and version handling
rqrrlibrary API by simplifying the QR code version handling2. Added comprehensive testing
tests/data/qr/3. Fixed build dependencies
korniadependency fromkornia-qrCargo.tomlto0.1.9-rc.2to match the workspace4. Created example application
qr_detectorexample inexamples/qr_detector/Testing
These changes make the QR code detection functionality in Kornia more robust and user-friendly while ensuring proper integration with the rest of the Kornia ecosystem.