Improve code quality in MentorDashboard.tsx #267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes 1. **Changed `==` to `===`** for strict equality (3 occurrences) 2. **Added return type annotation** `JSX.Element` to component 3. **Fixed useEffect dependencies** - added `auth` and `navigate` 4. **Added null safety** to reduce operations 5. **Added number formatting** using `toLocaleString()` to all stat values 6. **Added aria-label** to "Add a Project" link for accessibility ## Why - Follows TypeScript and ESLint best practices (strict equality) - Improves type safety with return type annotation - Fixes React Hooks exhaustive deps warning - Prevents potential runtime errors with null checks - Better UX - large numbers display with commas (e.g., 1,234 instead of 1234) - Improves accessibility for screen readers
👷 Deploy request for kwoc-2025 pending review.Visit the deploys page to approve it
|
|
@ProgrammerSONGBIT is attempting to deploy a commit to the Ankit Meda's projects Team on Vercel. A member of the Team first needs to authorize it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
==to===for strict equality (3 occurrences)JSX.Elementto componentauthandnavigatetoLocaleString()to all stat valuesWhy