Skip to content

Update bticino-camera.ts #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update bticino-camera.ts #1808

wants to merge 1 commit into from

Conversation

mrMiimo
Copy link

@mrMiimo mrMiimo commented May 20, 2025

Extended the doorbell motion timeout from 20s to 60s. HomeKit Secure Video (HKSV) clips were limited to ~10s due to the short event duration. By keeping the motion event active longer, HKSV can record longer clips if activity persists.

Extended the doorbell motion timeout from 20s to 60s.
HomeKit Secure Video (HKSV) clips were limited to ~10s due to the short event duration.
By keeping the motion event active longer, HKSV can record longer clips if activity persists.
@koush
Copy link
Owner

koush commented May 20, 2025

@slyoldfox

@slyoldfox
Copy link
Contributor

@mrMiimo did you build and deploy a patched version for you locally and can you confirm it actually works (because I'm running a whole other version of the plugin locally atm and I can't test it much myself).

@mrMiimo
Copy link
Author

mrMiimo commented May 20, 2025

@slyoldfox I wasn’t able to set up a full development environment, but considering the minimal scope of the change (just a value), I thought it wasn’t worth the overhead.
I’ll test it right away and, if needed, I’ll report back immediately so you can roll it back.

@slyoldfox
Copy link
Contributor

@slyoldfox I wasn’t able to set up a full development environment, but considering the minimal scope of the change (just a value), I thought it wasn’t worth the overhead. I’ll test it right away and, if needed, I’ll report back immediately so you can roll it back.

Just a bit of context, the value is choosen because the unit itself hangs up the connection around 30 seconds. So even though reset() only resets some variables, I was trying to keep it more or less aligned with that timing.

I also need to point out that the reset() probably will be happening earlier as well, since the main entry point is in the invite handler on https://github.com/koush/scrypted/blob/main/plugins/bticino/src/bticino-inviteHandler.ts#L27 - you will find the same timeout there.

I think at some point I did try to increase the values and I'm not sure that I ever got HKSV recording more than 10 seconds working (not sure where it goes wrong tbh). So please do fiddle around with it and test it out with an actual doorbell press on a local instance before we just merge this.

@koush koush closed this Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants