feat(bip0032): add SLIP-0010 support with secp256k1/nist256p1/ed25519#120
Conversation
koushiro
commented
Jan 25, 2026
koushiro
commented
- add slip10 traits, curve modules/backends, and feature flags
- add SLIP-0010 docs and test vectors; split bip32/slip10 tests
- update key helpers and curve error handling for new curves
- add slip10 traits, curve modules/backends, and feature flags - add SLIP-0010 docs and test vectors; split bip32/slip10 tests - update key helpers and curve error handling for new curves
dosubot
Bot
added
size:XXL
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5295a7716c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| type Bytes = [u8; 33]; | ||
|
|
||
| fn from_bytes(bytes: &Self::Bytes) -> Result<Self, Self::Error> { | ||
| if bytes[0] != 0 { | ||
| return Err(CurveError::from("invalid ed25519 public key prefix")); |
There was a problem hiding this comment.
SLIP-0010 defines Ed25519 public keys as 32 raw bytes; introducing a 33-byte encoding with a 0x00 prefix changes the public key serialization and therefore the parent fingerprint (hash160 over the serialized key) used throughout SLIP-0010 metadata. This will make derived fingerprints and public key bytes incompatible with standard SLIP-0010 vectors/implementations when users compare or interoperate across libraries.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
From https://github.com/satoshilabs/slips/blob/master/slip-0010.md#test-vector-1-for-ed25519, it is known that the calculation of the parent key fingerprint uses a 0x00 prefix plus a 32-byte ed25519 public key as input.
There was a problem hiding this comment.
add ed25519_pubkey_from_slip10_bytes/ed25519_pubkey_to_slip10_bytes and update docs about it
1 participant
