Add compatibility for Cabal 3.6.* inclusive#19
Open
ivb-supercede wants to merge 2 commits into
Open
Conversation
This makes two changes:
* For compatibility with 3.4+ without warnings, `fromComponents` has
been replaced with a call to `fromString` and `intercalate`.
* For compatibility with 3.6+, `Autopack.hs` now uses the C
preprocessor with Cabal's version flags to handle a breaking change
in the Cabal API around `hsSourceDirs`, which are now
`SymbolicPath`s instead of `FilePath`s.
(I know `getSymbolicPath` says "Don't use this in new code", but I can't
find any alternative - in the Cabal codebase, it *is* used in new code.)
Contributor
|
Hi @avnik, I'm not maintaining Kowainik projects anymore so you don't need to ping me 🙂 |
|
@chshersh So this project actually abandoned (same for co-log/relude?) @ivb-supercede could one of us overtake it upstream? |
Author
|
It looks to me like colog and relude are still being maintained. We can take over maintenance of autopack in order to publish this fix, if it's necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes two changes:
fromComponentshas been replaced with a call tofromStringandintercalate.Autopack.hsnow uses the C preprocessor with Cabal's version flags to handle a breaking change in the Cabal API aroundhsSourceDirs, which are nowSymbolicPaths instead ofFilePaths.(I know
getSymbolicPathsays "Don't use this in new code", but I can't find any alternative - in the Cabal codebase, it is used in new code.)