⚡ Optimize HTTPLoggerFunc performance when logging is disabled #121
Conversation
This commit introduces a performance optimization in `HTTPLoggerFunc`. It adds a check `if g.GetCurrentMode(LOG) != NONE` to skip unnecessary time calculations, argument evaluation, and slice allocation when logging is disabled. This change avoids the overhead of `fastime.UnixNanoNow()` and `Logf` argument preparation for requests when the LOG level is set to NONE.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: Guarded the logging logic in
HTTPLoggerFuncwithif g.GetCurrentMode(LOG) != NONE.🎯 Why: To prevent expensive argument evaluation (time duration string conversion) and allocations when logging is disabled.
📊 Measured Improvement:
Benchmark results showed significant improvement when logging is disabled (MODE=NONE):
This represents an ~86% reduction in execution time and elimination of allocations for the disabled logging case.
PR created automatically by Jules for task 9840227275770579066 started by @kpango