docs: update README JVM guidance for modern Java#140
docs: update README JVM guidance for modern Java#140shan305 wants to merge 2 commits intokpavlov:masterfrom
Conversation
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughREADME.md updated to remove CMS-specific JVM tuning lines and replace them with a new "JVM notes" section that recommends modern GC collectors (G1 default, ZGC/Shenandoah as appropriate) and notes Java 17 compatibility for running the examples. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🪛 markdownlint-cli2 (0.18.1)README.md66-66: Heading style (MD003, heading-style) 🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
README.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
66-66: Heading style
Expected: setext; Actual: atx
(MD003, heading-style)
66-66: Headings should be surrounded by blank lines
Expected: 1; Actual: 0; Below
(MD022, blanks-around-headings)
|
Thanks for the review! I’ve addressed the markdown spacing feedback by adding a blank line after the section heading. Happy to adjust further if needed. |
I built the project on Java 17 and noticed the README still referenced
legacy CMS GC flags, which are no longer supported on modern Java
versions.
This PR updates the README with modern JVM guidance and clarifies
Java 17 compatibility.