feat(ProducerSettings): enable producer settings when creating Stream…#396
Merged
Conversation
Contributor
|
marcosschroh
force-pushed
the
opt/add-producer-settings
branch
from
49e429d to
808ecd5
Compare
woile
reviewed
Jun 9, 2026
marcosschroh
force-pushed
the
opt/add-producer-settings
branch
from
808ecd5 to
56e9996
Compare
woile
reviewed
Jun 10, 2026
marcosschroh
force-pushed
the
opt/add-producer-settings
branch
from
56e9996 to
8f10207
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #396 +/- ##
==========================================
+ Coverage 96.78% 96.93% +0.14%
==========================================
Files 25 25
Lines 1121 1143 +22
==========================================
+ Hits 1085 1108 +23
+ Misses 36 35 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
woile
reviewed
Jun 10, 2026
woile
left a comment
woile
left a comment
Member
There was a problem hiding this comment.
LGTM, let me know when it's ready for review 👍🏻
woile
approved these changes
Jun 10, 2026
marcosschroh
force-pushed
the
opt/add-producer-settings
branch
from
f0fb910 to
7eadc92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Engine