Have function-runner output include image version tags in output by JamesMcDermott · Pull Request #4421 · kptdev/kpt

JamesMcDermott · 2026-03-03T13:24:05Z

Changes:

Update function-runner so that printed output lines, containing the function image names executed, also include image version tags:
- before running ("[RUNNING]" lines)
  - update runner.go so the display name in the printed output appends the function image's tag attribute (replacing any tag in the existing image attribute), OR leaves an existing tag in the image attribute if no tag attribute, OR defaults to "latest", in that order of preference
  - as per comment chain Have function-runner output include image version tags in output #4421 (comment), we're instead refactoring to resolve the image before running (at the point of function creation in runner.go). This allows the exact image version tag to be included in "[RUNNING]" lines as well
- after success/failure ("[PASS]" or "[FAIL]" lines)
  - update container.go to replace the display name in the printed output with the resolved image that was run, whether successfully or not
    - we replace the display name entirely because, with the introduction of semantic versioning constraint functionality the image that was actually resolved may differ significantly from the text provided in the tag attribute

Motivation:

When using the tag attribute (with or without a semantic version constraint) or when no version tag is included in either tag or image (defaulting to "latest"), function pipeline output does not usually include the version tag of the executed image.

Fixes: #4410

netlify · 2026-03-03T13:24:11Z

✅ Deploy Preview for kptdocs ready!

Name	Link
🔨 Latest commit	`cc79c89`
🔍 Latest deploy log	https://app.netlify.com/projects/kptdocs/deploys/69aeddc4590bef0008e80e91
😎 Deploy Preview	https://deploy-preview-4421--kptdocs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull request overview

Updates the function-runner’s CLI output so that function image names shown in [RUNNING], [PASS], and [FAIL] lines include version tag information (including semver constraints and latest defaults), improving observability when tag is used or when tags are implicit.

Changes:

Add Tag metadata to function results and use it to construct [RUNNING] display names with the right tag/constraint (defaulting to latest when needed).
Update container execution to overwrite the displayed image on completion with the resolved image actually executed (important for semver constraints).
Add unit test coverage for display-name construction and new e2e golden tests validating printed output.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
pkg/api/fnresult/v1/types.go	Adds `Tag` field to structured function result metadata.
internal/fnruntime/runner.go	Builds `[RUNNING]` display names including tag/constraint and updates name post-run to use resolved image.
internal/fnruntime/container.go	Updates `FnResult.Image` to the resolved image (or `:latest` when implicit) to drive `[PASS]/[FAIL]` output.
internal/fnruntime/runner_test.go	Adds table-driven tests for function image display-name construction.
e2e/testdata/fn-render/fn-failure-print-fn-version/starlark-failure-fn.yaml	Adds failing starlark config to validate `[FAIL]` output includes resolved tag.
e2e/testdata/fn-render/fn-failure-print-fn-version/resources.yaml	Adds resources for the failure scenario test package.
e2e/testdata/fn-render/fn-failure-print-fn-version/deployment_httpbin.yaml	Adds additional resource input for the failure scenario.
e2e/testdata/fn-render/fn-failure-print-fn-version/Kptfile	Defines a pipeline using `tag` so output must show constraint and resolved version.
e2e/testdata/fn-render/fn-failure-print-fn-version/.krmignore	Excludes `.expected` from function input processing.
e2e/testdata/fn-render/fn-failure-print-fn-version/.expected/config.yaml	Golden output asserting `[RUNNING]` shows constraint and `[FAIL]` shows resolved tag.
e2e/testdata/fn-render/basicpipeline-print-fn-versions/resources.yaml	Adds resources for the “basicpipeline” tag-printing scenario.
e2e/testdata/fn-render/basicpipeline-print-fn-versions/Kptfile	Exercises multiple tag cases: implicit latest, explicit tag, and semver constraints.
e2e/testdata/fn-render/basicpipeline-print-fn-versions/.krmignore	Excludes `.expected` from function input processing.
e2e/testdata/fn-render/basicpipeline-print-fn-versions/.expected/diff.patch	Golden diff output for resource mutations in the basic pipeline.
e2e/testdata/fn-render/basicpipeline-print-fn-versions/.expected/config.yaml	Golden stderr output asserting tag/constraint printing behavior across cases.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/fnruntime/container.go

internal/fnruntime/runner.go

internal/fnruntime/runner_test.go

pkg/api/fnresult/v1/types.go

Copilot

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/fnruntime/container.go

Copilot

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/fnruntime/runner.go

e2e/testdata/fn-render/fn-failure-print-fn-version/Kptfile

e2e/testdata/fn-render/basicpipeline-print-fn-versions/Kptfile

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/util/render/executor.go

efiacor · 2026-03-06T13:33:47Z

internal/fnruntime/container.go

 		}
 		f.Image, err = tagResolver.ResolveFunctionImage(f.Ctx, f.Image, f.Tag)
 		if err != nil {
+			f.FnResult.Image = buildFunctionDisplayName(f.FnResult)


For me, I think it would be better if we could get the ACTUAL image being RUN.
We could prob get this from the StdErr in the runCli fn below, the the f.FnResult.Image would display the exact tag/digest.

Not sure that's possible at this point - a few points:

Do you mean in this particular block? If we're at this line, we've had an error trying to resolve the Image and Tag (which we didn't know without trying if it had an exact version or SemVer constraint) to an actual image - there's no way to know what the actual image would have been that would have been run if we hadn't errored out. I think giving back the same tag as configured is the best we can do in this situation.

Do you mean in the [PASS]/[FAIL] lines after the run? That's already done by line 169 as is - a successful ResolveFunctionImage() call will have updated f.Image to include the exact resolved tag

Do you mean in [RUNNING] output lines in general? That's not currently possible because at the point of resolving the actual image, the [RUNNING] line has already been printed, back in FunctionRunner.Filter() in internal/fnruntime/runner.go. The printing there serves double duty for both Image and Exec runs - it'd be a lot of extra work (and repetition in wasm.go and exec.go) to split it out to a point where we can wait to print until we've resolved the actual image.

Perhaps a redesign where we pull the use of ResolveFunctionImage() back up to the creation of the ContainerFn f at runner.go line 108? That would probably work, but it seems like it would break the separation of "part where we're setting up and configuring" from "part where we start going on the network and actually running things". Let me know anyway. :)

No, doesn't matter where the functionality lives, but just looking at the sample [RUNNING] output in some of the tests, I don't think it's that useful. ie [RUNNING] "ghcr.io/kptdev/krm-functions-catalog/set-namespace:0.4.1 - 0.4.3"
If we can get the exact tag/digest, I think it would be more useful for the user.

Ah - fair enough. Reworked to bring it up to runner.go and added a new line type, [RESOLUTION FAIL].

example: Package: "nginx" [RUNNING] "ghcr.io/kptdev/krm-functions-catalog/kubeconform:latest" [PASS] "ghcr.io/kptdev/krm-functions-catalog/kubeconform:latest" in 2.4s Successfully executed 1 function(s) in 1 package(s) Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

- also linting changes - also minor AI-suggested refactors for better readbility Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

- when `tag` present and image resolution errors out, add `tag` to printed image name - also new e2e test for this specific failure - reuse pre-run display name building logic Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

- minor Copilot review comments Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

- also addresses Copilot comment Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

- allows us to have exact resolved image version tags in [RUNNING] output lines as well as [PASS]/[FAIL] - add new [RESOLUTION FAIL] line type to account for image resolution failure Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Copilot

Pull request overview

Copilot reviewed 20 out of 20 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

internal/fnruntime/runner.go

pkg/api/fnresult/v1/types.go

Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Copilot AI review requested due to automatic review settings March 3, 2026 13:24

JamesMcDermott requested review from efiacor, kispaljr, liamfallon and mozesl-nokia as code owners March 3, 2026 13:24

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. area/fn-runtime KRM function runtime labels Mar 3, 2026

Copilot started reviewing on behalf of JamesMcDermott March 3, 2026 13:24 View session

Copilot AI reviewed Mar 3, 2026

View reviewed changes

internal/fnruntime/container.go Outdated Show resolved Hide resolved

internal/fnruntime/runner.go Outdated Show resolved Hide resolved

internal/fnruntime/runner_test.go Show resolved Hide resolved

pkg/api/fnresult/v1/types.go Outdated Show resolved Hide resolved

JamesMcDermott force-pushed the cli-print-function-versions branch from fee7097 to bfcda2c Compare March 3, 2026 13:33

Copilot AI review requested due to automatic review settings March 4, 2026 10:16

Copilot started reviewing on behalf of JamesMcDermott March 4, 2026 10:17 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

internal/fnruntime/container.go Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings March 4, 2026 14:02

Copilot started reviewing on behalf of JamesMcDermott March 4, 2026 14:02 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings March 4, 2026 17:14

Copilot started reviewing on behalf of JamesMcDermott March 4, 2026 17:15 View session

Copilot AI reviewed Mar 4, 2026

View reviewed changes

internal/util/render/executor.go Outdated Show resolved Hide resolved

JamesMcDermott force-pushed the cli-print-function-versions branch from 3651d10 to bffca20 Compare March 5, 2026 09:31

efiacor reviewed Mar 6, 2026

View reviewed changes

JamesMcDermott added 8 commits March 6, 2026 15:47

Add tests for including function image tags in output

b455057

- also linting changes - also minor AI-suggested refactors for better readbility Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

update missed copyright year

dfb4f7f

Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Add e2e test for [FAIL] output

886f11a

Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Addresses Copilot review comments

9ab2c5d

Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Fix copyright headers

d9357e4

Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Account for "builtins/*" pseudo-images - no tagging

ff146bb

- minor Copilot review comments Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

JamesMcDermott added 3 commits March 6, 2026 15:47

nitpick to retrigger CI

47f3812

Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Comment fix to retrigger CI

9d530a2

- also addresses Copilot comment Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Copilot AI review requested due to automatic review settings March 9, 2026 10:18

JamesMcDermott force-pushed the cli-print-function-versions branch from bffca20 to 0c54533 Compare March 9, 2026 10:18

Copilot started reviewing on behalf of JamesMcDermott March 9, 2026 10:18 View session

Copilot AI reviewed Mar 9, 2026

View reviewed changes

internal/fnruntime/runner.go Show resolved Hide resolved

internal/fnruntime/runner.go Show resolved Hide resolved

pkg/api/fnresult/v1/types.go Outdated Show resolved Hide resolved

Refactor out addition of Result.Tag - no longer necessary

cc79c89

Signed-off-by: JamesMcDermott <james.j.mcdermott@ericsson.com>

Conversation

JamesMcDermott commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes:

Motivation:

Fixes: #4410

Uh oh!

netlify bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kptdocs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

efiacor Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

JamesMcDermott Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

efiacor Mar 6, 2026

Choose a reason for hiding this comment

Uh oh!

JamesMcDermott Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

JamesMcDermott commented Mar 3, 2026 •

edited

Loading

netlify bot commented Mar 3, 2026 •

edited

Loading