introduce DisplayName option in renderOptions#4476
Conversation
dgyorgy-nokia
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
dosubot
Bot
added
size:XS
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Syncs a missing change from the porch fork by extending renderer configuration to support a human-friendly renderer “DisplayName” (primarily for logging in the async render pipeline).
Changes:
- Add
DisplayNametoRenderOptionsfor renderer identification/logging. - Reformat
RenderOptionsfield alignment for readability.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dosubot
Bot
added
size:M
dgyorgy-nokia
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Daniel Gyorgy <daniel.gyorgy@nokia.com>
Signed-off-by: Daniel Gyorgy <daniel.gyorgy@nokia.com>
Signed-off-by: Daniel Gyorgy <daniel.gyorgy@nokia.com>
dgyorgy-nokia
force-pushed
the
async-pipeline
branch
from
2349ea3 to
2d5160d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
Sync changes from porch (nokia-fork)
This logging related change is still missing from the kpt, which is modified back in the porch repository. This is used by the async render pipeline implementation.
Mainly is just about having an optional DisplayName field for the Renderer for logging purposes.
Related porch issue: nephio-project/nephio#922