Skip to content

Improve kpt version resolution in setup-go-kpt composite action #4730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aravindtga wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −4
Open

Improve kpt version resolution in setup-go-kpt composite action #4730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions .github/actions/setup-go-kpt/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,18 @@ inputs:
kpt-fallback-version:
description: "Fallback kpt version if extraction from go.mod fails"
required: false
default: "v1.0.0-beta.65"
default: "v1.0.0"
go-version:
description: "Exact version for Go version setup, go-version-file is ignored if set"
required: false
go-version-file:
description: "Path to go.mod file for Go version setup"
required: false
default: "go.mod"
kpt-version-file:
description: "Path to the go.mod file used to resolve the kpt version. Defaults to go-version-file."
required: false
default: ""
go-cache:
description: "Enable Go module caching"
required: false
Expand Down Expand Up @@ -62,14 +66,26 @@ runs:
shell: bash
env:
GO_VERSION_FILE: ${{ inputs.go-version-file }}
KPT_VERSION_FILE: ${{ inputs.kpt-version-file }}
KPT_FALLBACK: ${{ inputs.kpt-fallback-version }}
run: |
GO_MOD_DIR=$(dirname -- "$GO_VERSION_FILE")
KPT_VERSION=$(cd "$GO_MOD_DIR" && go list -m -f '{{.Version}}' github.com/kptdev/kpt 2>/dev/null)
set -euo pipefail
VERSION_FILE="${KPT_VERSION_FILE:-$GO_VERSION_FILE}"
KPT_VERSION=""
if [ ! -f "$VERSION_FILE" ]; then
echo "::warning::kpt version file '${VERSION_FILE}' not found; using fallback ${KPT_FALLBACK}."
else
GO_MOD_DIR=$(dirname -- "$VERSION_FILE")
KPT_VERSION=$(cd "$GO_MOD_DIR" && go mod edit -json \
| jq -r '(.Require[]? | select(.Path=="github.com/kptdev/kpt") | .Version) // ""')
if [ -z "$KPT_VERSION" ]; then
echo "::warning::Could not resolve github.com/kptdev/kpt from ${VERSION_FILE}; using fallback ${KPT_FALLBACK}."
fi
fi
if [ -z "$KPT_VERSION" ]; then
echo "Warning: Could not resolve kpt version from ${GO_VERSION_FILE}, using fallback."
KPT_VERSION="$KPT_FALLBACK"
fi
echo "Using kpt version: ${KPT_VERSION}"
echo "version=${KPT_VERSION}" >> "$GITHUB_OUTPUT"

- name: Install kpt
Expand Down