Skip to content

Conversation

@samueljsb
Copy link
Contributor

No description provided.

This matches other lists in this file and is more intuitive.
@samueljsb samueljsb marked this pull request as ready for review October 1, 2025 22:03
@samueljsb samueljsb requested a review from a team as a code owner October 1, 2025 22:03
Copy link
Collaborator

@meshy meshy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I think it's worth adding changes to the test matrix to the change log. Can I please ask you to add that before merging?

README.md Outdated
Comment on lines 96 to 97
- Python 3.10, 3.11, 3.12, 3.13, or 3.14.
- Django 4.1, 4.2, or 5.0.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I think these are "and"...

Comment on lines 4 to +5
py3{10,11}-django41-psycopg2
py3{10,11,12,13}-django{42,50}-psycopg{2,3}
py3{10,11,12,13,14}-django{42,50}-psycopg{2,3}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Perhaps this is out of scope for this PR, but we should also update the Django matrix.

@samueljsb samueljsb merged commit e5e91a6 into main Oct 2, 2025
9 checks passed
@samueljsb samueljsb deleted the python3.14 branch October 2, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants