Fix test dbs and gitignore #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some local development environments were failing to connect to postgres
with this error:
django.db.utils.OperationalError: connection failed:
connection to server at "127.0.0.1", port 5432 failed:
fe_sendauth: no password supplied
At first, this error was hidden by this warning (which we turn into an
error):
RuntimeWarning:
Normally Django will use a connection to the 'postgres' database
to avoid running initialization queries against the production
database when it's not needed (for example, when running tests).
Django was unable to create a connection to the 'postgres'
database and will use the first PostgreSQL database instead.
By not defining the host as `localhost` in the test settings, tests run
correctly.
Co-authored-by: Charlie Denton <[email protected]>
LilyFirefly
force-pushed
the
fix-test-dbs-and-gitignore
branch
from
4ef8b60 to
90b1cdf
Compare
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some local development environments were failing to connect to postgres with this error:
At first, this error was hidden by this warning (which we turn into an error):
By not defining the host as
localhostin the test settings, tests run correctly.Add coverage generated files to
.gitignoreto prevent accidentally committing them.