Simplify error handling with ? and ok_or_else
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simplifies the error handling in the `Bundle::new` and `Bundle::get_translation` functions by using the `?` operator and the `ok_or_else` infix method available for `Option<T>`. This makes the code more concise and easier to read.
dooferlad
approved these changes
Jan 28, 2025
|
@dooferlad I don't quite have write access, please feel free to merge this 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the error handling in the
Bundle::newandBundle::get_translationfunctions by using the?operator and theok_or_elseinfix method available forOption<T>.This makes the code more concise and easier to read.