Make edlink n8 cross-platform by upgrading project to .NET SDK - #10
Open
LVS12122 wants to merge 4 commits into
Open
Make edlink n8 cross-platform by upgrading project to .NET SDK#10LVS12122 wants to merge 4 commits into
LVS12122 wants to merge 4 commits into
Conversation
… 10.0 - Convert project from legacy .NET Framework format to modern SDK-style format - Upgrade target framework from .NET Framework 4.7.2 to .NET 10.0 (LTS) - Replace legacy assembly references with NuGet packages: - System.IO.Ports (for serial communication) - System.Drawing.Common (for graphics operations) - Clean up AssemblyInfo.cs to let SDK auto-generate assembly attributes - Project now builds successfully with C# Dev Kit This modernization enables the project to work with Visual Studio 2024 C# Dev Kit and benefit from modern .NET features and performance improvements.
…nneeded app config
- Remove System.Drawing.Common package (Windows-only) - Add SkiaSharp package (cross-platform graphics library) - Update MenuImage.cs to use SkiaSharp APIs: - SKSurface/SKCanvas instead of Bitmap - DrawPoint instead of SetPixel - PNG encoding instead of Save method - Project now builds and runs on macOS, Windows, and Linux - Maintains identical functionality for NES image generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Feel free to deny this PR if you want to stick with .NET Framework for whatever reason)
This PR modernizes the project to work with .NET SDK, which allows for building on Windows, Mac, and Linux (with "dotnet build edlink-n8/edlink-n8.sln"). It also integrates nicely with C# Dev Kit in VS Code (I included the VS Code Build Tasks for convenience).
Also for the screenshot option, I needed to swap out the Bitmap class with a cross-platform option called SkiaSharp. I've tested this (on Mac) as well as running a .nes, and running diagnostics, and they all work great. The only thing that hasn't worked that i tested was -cp, but it seems to be a separate issue.