Skip to content

Fix expansion controller reading in NSF player - #2

Open
consolethinks wants to merge 2 commits into
krikzz:mainfrom
consolethinks:master
Open

Fix expansion controller reading in NSF player#2
consolethinks wants to merge 2 commits into
krikzz:mainfrom
consolethinks:master

Conversation

@consolethinks

Copy link
Copy Markdown

NSF Player fix

  • Optimised code a little by removing useless nop's from controller reading routine (can be omitted from this request)
  • More importantly, it fixes expansion controller reading for Famicom users with third party controllers.
    Note that this fix aligns with how the menu reads controllers (both internal and external) and still keeps the DPCM safeguard

@consolethinks consolethinks left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix: RAM reset for proper playback of certain NSF files

  • If the game's sound driver depends on internal RAM or WRAM, those sometimes need to be reset to avoid certain channels from continuing playback of the previous track
  • This second commit fixes this issue by adding a RAM reset code to the init, while also skipping the stack

Example NSF: A nightmare on Elm Street (sound effects mainly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant