Chore/update dependencies 2026 03#22
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+17
to
+102
| runs-on: ubuntu-22.04 | ||
| environment: testing | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: "20" | ||
|
|
||
| - name: Install dependencies for frontend | ||
| run: cd frontend && npm install && cd .. | ||
| - name: Install dependencies for frontend | ||
| run: cd frontend && npm install && cd .. | ||
|
|
||
| - name: Install dependencies for backend | ||
| run: cd backend && npm install && cd .. | ||
| - name: Install dependencies for backend | ||
| run: cd backend && npm install && cd .. | ||
|
|
||
| - name: Lint frontend | ||
| run: cd frontend && npm run lint && cd .. | ||
| - name: Lint frontend | ||
| run: cd frontend && npm run lint && cd .. | ||
|
|
||
| - name: Lint backend | ||
| run: cd backend && npm run lint && cd .. | ||
| - name: Lint backend | ||
| run: cd backend && npm run lint && cd .. | ||
|
|
||
| - name: Build frontend | ||
| run: cd frontend && npm run build:testing | ||
| env: | ||
| VITE_MAPBOX_API: ${{ secrets.VITE_MAPBOX_API }} | ||
| VITE_FIREBASE_TESTING_API_KEY: ${{ secrets.VITE_FIREBASE_TESTING_API_KEY }} | ||
| VITE_FIREBASE_TESTING_AUTH_DOMAIN: ${{ secrets.VITE_FIREBASE_TESTING_AUTH_DOMAIN }} | ||
| VITE_FIREBASE_TESTING_PROJECT_ID: ${{ secrets.VITE_FIREBASE_TESTING_PROJECT_ID }} | ||
| VITE_FIREBASE_TESTING_STORAGE_BUCKET: ${{ secrets.VITE_FIREBASE_TESTING_STORAGE_BUCKET }} | ||
| VITE_FIREBASE_TESTING_MESSAGING_SENDER_ID: ${{ secrets.VITE_FIREBASE_TESTING_MESSAGING_SENDER_ID }} | ||
| VITE_FIREBASE_TESTING_APP_ID: ${{ secrets.VITE_FIREBASE_TESTING_APP_ID }} | ||
| MODE: testing | ||
| - name: Build frontend | ||
| run: cd frontend && npm run build:testing | ||
| env: | ||
| VITE_MAPBOX_API: ${{ secrets.VITE_MAPBOX_API }} | ||
| VITE_FIREBASE_TESTING_API_KEY: ${{ secrets.VITE_FIREBASE_TESTING_API_KEY }} | ||
| VITE_FIREBASE_TESTING_AUTH_DOMAIN: ${{ secrets.VITE_FIREBASE_TESTING_AUTH_DOMAIN }} | ||
| VITE_FIREBASE_TESTING_PROJECT_ID: ${{ secrets.VITE_FIREBASE_TESTING_PROJECT_ID }} | ||
| VITE_FIREBASE_TESTING_STORAGE_BUCKET: ${{ secrets.VITE_FIREBASE_TESTING_STORAGE_BUCKET }} | ||
| VITE_FIREBASE_TESTING_MESSAGING_SENDER_ID: ${{ secrets.VITE_FIREBASE_TESTING_MESSAGING_SENDER_ID }} | ||
| VITE_FIREBASE_TESTING_APP_ID: ${{ secrets.VITE_FIREBASE_TESTING_APP_ID }} | ||
| MODE: testing | ||
|
|
||
| - name: Build backend | ||
| run: cd backend && npm run build:testing | ||
| env: | ||
| NODE_ENV: test | ||
| MONGODB_TESTING_URI: ${{secrets.MONGODB_TEST_URI}} | ||
| SECRET: ${{ secrets.SECRET }} | ||
| PORT: ${{ secrets.PORT }} | ||
| FIREBASE_TESTING_CLIENT_EMAIL: ${{ secrets.FIREBASE_CLIENT_EMAIL }} | ||
| FIREBASE_TESTING_PRIVATE_KEY: ${{ secrets.FIREBASE_PRIVATE_KEY }} | ||
| FIREBASE_TESTING_PROJECT_ID: ${{ secrets.FIREBASE_PROJECT_ID }} | ||
| - name: Build backend | ||
| run: cd backend && npm run build:testing | ||
| env: | ||
| NODE_ENV: test | ||
| MONGODB_TESTING_URI: ${{secrets.MONGODB_TEST_URI}} | ||
| SECRET: ${{ secrets.SECRET }} | ||
| PORT: ${{ secrets.PORT }} | ||
| FIREBASE_TESTING_CLIENT_EMAIL: ${{ secrets.FIREBASE_CLIENT_EMAIL }} | ||
| FIREBASE_TESTING_PRIVATE_KEY: ${{ secrets.FIREBASE_PRIVATE_KEY }} | ||
| FIREBASE_TESTING_PROJECT_ID: ${{ secrets.FIREBASE_PROJECT_ID }} | ||
|
|
||
| - name: Start backend | ||
| run: | | ||
| cd backend && npm run start:built-testing & | ||
| for i in {1..50}; do | ||
| if curl --silent --fail http://localhost:${{ secrets.PORT }}/api/testing/reset > /dev/null; then | ||
| sleep 1 | ||
| echo "Backend started" | ||
| break | ||
| fi | ||
| echo "Waiting for backend..." | ||
| sleep 1 | ||
| done | ||
| env: | ||
| NODE_ENV: testing | ||
| MONGODB_TESTING_URI: ${{secrets.MONGODB_TEST_URI}} | ||
| SECRET: ${{ secrets.SECRET }} | ||
| PORT: ${{ secrets.PORT }} | ||
| FIREBASE_TESTING_CLIENT_EMAIL: ${{ secrets.FIREBASE_CLIENT_EMAIL }} | ||
| FIREBASE_TESTING_PRIVATE_KEY: ${{ secrets.FIREBASE_PRIVATE_KEY }} | ||
| FIREBASE_TESTING_PROJECT_ID: ${{ secrets.FIREBASE_PROJECT_ID }} | ||
| - name: Start backend | ||
| run: | | ||
| cd backend && npm run start:built-testing & | ||
| for i in {1..50}; do | ||
| if curl --silent --fail http://localhost:${{ secrets.PORT }}/api/testing/reset > /dev/null; then | ||
| sleep 1 | ||
| echo "Backend started" | ||
| break | ||
| fi | ||
| echo "Waiting for backend..." | ||
| sleep 1 | ||
| done | ||
| env: | ||
| NODE_ENV: testing | ||
| MONGODB_TESTING_URI: ${{secrets.MONGODB_TEST_URI}} | ||
| SECRET: ${{ secrets.SECRET }} | ||
| PORT: ${{ secrets.PORT }} | ||
| FIREBASE_TESTING_CLIENT_EMAIL: ${{ secrets.FIREBASE_CLIENT_EMAIL }} | ||
| FIREBASE_TESTING_PRIVATE_KEY: ${{ secrets.FIREBASE_PRIVATE_KEY }} | ||
| FIREBASE_TESTING_PROJECT_ID: ${{ secrets.FIREBASE_PROJECT_ID }} | ||
|
|
||
| - name: Cypress E2E tests | ||
| uses: cypress-io/github-action@v5 | ||
| with: | ||
| working-directory: frontend | ||
| command: npm run cy:e2e | ||
| wait-on: ${{ secrets.CYPRESS_BASE_URL }} | ||
| env: | ||
| CYPRESS_TEST_EMAIL: ${{ secrets.CYPRESS_TEST_EMAIL }} | ||
| CYPRESS_BASE_URL: ${{ secrets.CYPRESS_BASE_URL }} | ||
| Deploy: | ||
| name: Deploy to Render | ||
| needs: Lint-Build-Test | ||
| runs-on: ubuntu-latest | ||
| environment: testing | ||
| if: ${{ github.event_name == 'push' && contains(github.event.head_commit.message, '#DEPLOY') }} | ||
| steps: | ||
| - name: Trigger deployment | ||
| run: curl ${{ secrets.RENDER_DEPLOY_URL }} | ||
| - name: Cypress E2E tests | ||
| uses: cypress-io/github-action@v5 | ||
| with: | ||
| working-directory: frontend | ||
| command: npm run cy:e2e | ||
| wait-on: ${{ secrets.CYPRESS_BASE_URL }} | ||
| env: | ||
| CYPRESS_TEST_EMAIL: ${{ secrets.CYPRESS_TEST_EMAIL }} | ||
| CYPRESS_BASE_URL: ${{ secrets.CYPRESS_BASE_URL }} | ||
|
|
||
| Tag: | ||
| runs-on: ubuntu-latest | ||
| needs: Lint-Build-Test | ||
| if: ${{ github.event_name == 'push' && contains(github.event.head_commit.message, '#RELEASE') }} | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| - uses: anothrNick/github-tag-action@1.67.0 | ||
| name: Bump version and push tag | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| DEFAULT_BUMP: patch | ||
| # now in our own VPS :) | ||
| # Deploy: | ||
| # name: Deploy to Render | ||
| # needs: Lint-Build-Test | ||
| # runs-on: ubuntu-latest | ||
| # environment: testing | ||
| # if: ${{ github.event_name == 'push' && contains(github.event.head_commit.message, '#DEPLOY') }} | ||
| # steps: | ||
| # - name: Trigger deployment | ||
| # run: curl ${{ secrets.RENDER_DEPLOY_URL }} | ||
|
|
||
| Tag: |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
In general, the problem is fixed by adding an explicit permissions: block that grants only the minimal GITHUB_TOKEN scopes needed. This can be defined at the top level of the workflow (applying to all jobs) and overridden per-job where broader access is required.
For this workflow, the Lint-Build-Test job does not perform any repository writes; it only checks out code, installs dependencies, builds, and runs tests. It therefore only needs contents: read. The Tag job uses anothrNick/github-tag-action to create and push tags; this job needs contents: write. The best fix while preserving current behavior is:
- Add a root-level
permissions:block aftername:(line 1) settingcontents: read. This will apply to all jobs by default. - Add a
permissions:block under theTag:job (around line 103) specifyingcontents: writeso that the tag action can still push tags.
No additional imports or methods are required; this is a pure workflow YAML change confined to .github/workflows/build-and-test.yml.
Suggested changeset
1
.github/workflows/build-and-test.yml
| @@ -1,4 +1,6 @@ | ||
| name: Lint, build, test, deploy and tag | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: | ||
| @@ -104,6 +106,8 @@ | ||
| runs-on: ubuntu-latest | ||
| needs: Lint-Build-Test | ||
| if: ${{ github.event_name == 'push' && contains(github.event.head_commit.message, '#RELEASE') }} | ||
| permissions: | ||
| contents: write | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 |
Copilot is powered by AI and may make mistakes. Always verify output.
Comment on lines
+103
to
+113
| runs-on: ubuntu-latest | ||
| needs: Lint-Build-Test | ||
| if: ${{ github.event_name == 'push' && contains(github.event.head_commit.message, '#RELEASE') }} | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| - uses: anothrNick/github-tag-action@1.67.0 | ||
| name: Bump version and push tag | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| DEFAULT_BUMP: patch |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 3 months ago
In general, the fix is to explicitly declare permissions for the workflow or for individual jobs so that the GITHUB_TOKEN has only the scopes required. Here, Lint-Build-Test only needs read access to checkout code and install dependencies, so it can be limited to contents: read. The Tag job needs to push tags, which requires contents: write.
The best way to fix this without changing existing functionality is:
- Add a workflow-level
permissionsblock near the top (aftername:) settingcontents: read. This applies to all jobs by default. - Add a
permissionsblock under theTagjob that overrides the default and setscontents: write, allowing it to push tags.
Concretely:
-
Edit
.github/workflows/build-and-test.yml. -
Insert:
permissions: contents: read
between line 1 (
name: ...) and line 3 (on:). -
Under the
Tag:job (after line 104runs-on: ubuntu-latest), insert:permissions: contents: write
preserving indentation. No imports or other definitions are needed.
Suggested changeset
1
.github/workflows/build-and-test.yml
| @@ -1,5 +1,8 @@ | ||
| name: Lint, build, test, deploy and tag | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| @@ -102,6 +105,8 @@ | ||
|
|
||
| Tag: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write | ||
| needs: Lint-Build-Test | ||
| if: ${{ github.event_name == 'push' && contains(github.event.head_commit.message, '#RELEASE') }} | ||
| steps: |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.