feat: Add configurable drawer sections with custom order #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vais
commented
Mar 25, 2025
|
|
||
| return substitute(name, '^'.db_ui#utils#slug(a:db.name).'-', '', '') | ||
| endfunction | ||
|
|
Contributor
Author
There was a problem hiding this comment.
All the code in the new render methods below is copied verbatum from the original if/elseif/endif above.
autoload/db_ui/drawer.vim
Outdated
|
|
||
| " Default drawer sections and their order | ||
| if !exists('g:db_ui_drawer_sections') | ||
| let g:db_ui_drawer_sections = ['new_query', 'buffers', 'saved_queries', 'schemas'] |
Owner
There was a problem hiding this comment.
Let's add the default in plugin/db_ui.vim where other defaults are. This should also fix the tests.
kristijanhusak
requested changes
Mar 25, 2025
Owner
kristijanhusak
left a comment
kristijanhusak
left a comment
There was a problem hiding this comment.
I missed the default variable value. Let's fix that and it's good to go.
Contributor
Author
|
My bad, @kristijanhusak, thanks for catching that! I've now moved (There are still 5 failing tests, but they appear to be the same ones that fail on master) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #299 and then some.
Thank you for creating this wonderful plugin, and thanks in advance for considering my changes.