Closure Api added default language to ensure compilation#799
Open
boekkooi wants to merge 1 commit intokriswallsmith:masterfrom
Open
Closure Api added default language to ensure compilation#799boekkooi wants to merge 1 commit intokriswallsmith:masterfrom
boekkooi wants to merge 1 commit intokriswallsmith:masterfrom
Conversation
|
This has been implemented in the 2.0 branch of assetic-php/assetic. Until we tag 2.0, you can pull it in by using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the failing CompilerApiFilterTest.
It seems that the closure compiler API requires a language to be set to be able to return compiled code. According to the language docs it would default to 'ECMASCRIPT3' but this seems not to be the case that is why setting this as the default fixes the failing test.