Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: paigerube14, tsebastiani The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Collaborator
Author
|
@chaitanyaenr @shahsahil264 can you pull the code down and review when you have time, lots of changes here |
paigerube14
force-pushed
the
krkn_lib_cerb
branch
from
1551fe1 to
5aab083
Compare
|
New changes are detected. LGTM label has been removed. |
paigerube14
force-pushed
the
krkn_lib_cerb
branch
2 times, most recently
from
085a40d to
0168942
Compare
paigerube14
force-pushed
the
krkn_lib_cerb
branch
from
2fb0621 to
02b3bda
Compare
Signed-off-by: Paige Rubendall <prubenda@redhat.com> Signed-off-by: Auto User <auto@users.noreply.github.com>
paigerube14
force-pushed
the
krkn_lib_cerb
branch
from
02b3bda to
c754eec
Compare
Collaborator
Author
|
@chaitanyaenr if you have time can you review this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Want to use common krkn-lib functions within cerberus to take out duplicate functions
This work is used in conjunction with this pr: krkn-chaos/krkn-lib#82