Skip to content

# Fix Silent Failure in Composite Scenarios by Evaluating All Scenario Exit Codes #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WHOIM1205 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

# Fix Silent Failure in Composite Scenarios by Evaluating All Scenario Exit Codes #121

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions krkn_ai/chaos_engines/krkn_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,16 +533,40 @@ def __extract_returncode_from_run(
json_str = "\n".join(json_lines)
chaos_data = json.loads(json_str)

# Extract exit_status from first scenario
# Extract exit_status from all scenarios (for composite scenarios)
# Return the worst exit status: misconfiguration errors (!=0,!=2) > SLO failures (2) > success (0)
scenarios = chaos_data.get("telemetry", {}).get("scenarios", [])
if scenarios and len(scenarios) > 0:
exit_status = scenarios[0].get("exit_status", default_returncode)
run_uuid = chaos_data.get("telemetry", {}).get("run_uuid", None)
logger.debug("Extracted exit_status: %s", exit_status)

worst_exit_status = 0
failed_scenarios = []

for scenario in scenarios:
exit_status = scenario.get("exit_status", 0)
scenario_name = scenario.get("name", "unknown")

if exit_status != 0:
failed_scenarios.append((scenario_name, exit_status))
# Prioritize misconfiguration errors over SLO failures
if worst_exit_status == 0:
worst_exit_status = exit_status
elif exit_status != 2 and worst_exit_status == 2:
# Misconfiguration error takes precedence over SLO failure
worst_exit_status = exit_status

if failed_scenarios:
logger.warning(
"Scenario failures detected in composite run: %s",
failed_scenarios
)

logger.debug("Extracted worst exit_status: %s from %d scenarios",
worst_exit_status, len(scenarios))
logger.debug("Extracted run_uuid: %s", run_uuid)
return exit_status, run_uuid
return worst_exit_status, run_uuid

logger.warning("No exit_status found in telemetry data")
logger.warning("No scenarios found in telemetry data")
return default_returncode, None

except Exception as e:
Expand Down