Adding pod name to krkn ctl and template#247
Merged
chaitanyaenr merged 4 commits intokrkn-chaos:mainfrom May 8, 2025
Merged
Conversation
paigerube14
force-pushed
the
pod_network_pod
branch
from
5ade325 to
0c8ad9f
Compare
tsebastiani
reviewed
Apr 7, 2025
Contributor
tsebastiani
left a comment
tsebastiani
left a comment
There was a problem hiding this comment.
/LGTM there's only a small typo that I've commented
chaitanyaenr
approved these changes
Apr 7, 2025
Signed-off-by: Paige Patton <prubenda@redhat.com>
paigerube14
force-pushed
the
pod_network_pod
branch
from
0c8ad9f to
5e45261
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the pod network scenario, a user was hitting issues running the scenario with the "NAMESPACE and POD_NAME variables but no LABEL_SELECTOR, and the test errored out stating that the POD_NAME variable needed to be set since the LABEL_SELECTOR variable was unset, even though we did have the POD_NAME variable in place."
The error message was unclear based on label selector being set from the krknctl side