fix: preserve owner references during resource updates #261
+34
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During resource updates, we now maintain owner references on resources managed by the controller, similar to how we already preserve finalizers. This ensures that existing ownership relationships are not disrupted during reconciliation. Added integration tests to verify both finalizers and owner references are preserved when resources are updated.
|
Do |
|
Cluster scoped resources cannot use namespace scoped ownerrefs. We definitely need an alternative mechanism. Or treat Cluster scoped resources as special cases. |
|
Having ownerrefs is important as a fallback for cleanup. K8s ownerrefs are namespace scoped by design. |
barney-s
reviewed
Feb 4, 2025
| @@ -273,6 +273,8 @@ func (igr *instanceGraphReconciler) updateResource( | |||
| // TODO: Handle annotations | |||
| desired.SetResourceVersion(observed.GetResourceVersion()) | |||
| desired.SetFinalizers(observed.GetFinalizers()) | |||
| desired.SetOwnerReferences(observed.GetOwnerReferences()) | |||
There was a problem hiding this comment.
Is this for adoption use cases ?
What about setting ownerref to the instance ?
n3wscott
reviewed
Mar 20, 2025
Comment on lines
275
to
+276
| desired.SetFinalizers(observed.GetFinalizers()) | ||
| desired.SetOwnerReferences(observed.GetOwnerReferences()) |
There was a problem hiding this comment.
Are you sure you can flat copy the observed into the desired? Has a merge already happened?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During resource updates, we now maintain owner references on resources managed by
the controller, similar to how we already preserve finalizers. This ensures that
existing ownership relationships are not disrupted during reconciliation. Added
integration tests to verify both finalizers and owner references are preserved
when resources are updated.