fix: Support referencing metadata fields in RGD. #377 #378
Conversation
SanjayUG
changed the title
There was a problem hiding this comment.
Hey @SanjayUG, thank you for your PR! Suggestion for this PR: can you intially address the bug for instance statuses first? as mentioned here #377 (comment)
We need to agree whether renaming schema to instance is the right call before starting the implementation.
examples/test-metadata.yaml
Outdated
There was a problem hiding this comment.
Are you willing to keep this file in your PR? if yes, can we move it somewhere under examples/kuberetes/*?
| if emulatedResource.Object["metadata"] == nil { | ||
| emulatedResource.Object["metadata"] = map[string]interface{}{ | ||
| "name": "dummy-name", | ||
| "creationTimestamp": "2024-01-01T00:00:00Z", | ||
| "namespace": "default", | ||
| "labels": map[string]interface{}{}, | ||
| "annotations": map[string]interface{}{}, | ||
| } | ||
| } |
There was a problem hiding this comment.
I believe that we already set fake metadata on emulated resources here https://github.com/kro-run/kro/blob/main/pkg/graph/emulator/emulator.go#L70-L74
There was a problem hiding this comment.
Thank you for deep diving,
I believe it helps in future development in the project.
If it is really not required then i welcome to notify me.
Hi developer,
This contribution fixes the #377 issue,
Support metadata field access in RGD CEL expressions
Adds support for referencing metadata fields in Resource Graph Definition (RGD) CEL expressions. Users can now access: