Fix make build rule #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

a-hilaly merged 1 commit into kro-run:main from n3wscott:fix-build-quite

Apr 1, 2025

Contributor

n3wscott commented Apr 1, 2025

I did not quote the ld flags in the #452 which resulted in:

go build -ldflags=-buildid= -X sigs.k8s.io/release-utils/version.gitVersion=v0.2.2-61-g35cb149-dirty -X sigs.k8s.io/release-utils/version.gitCommit=35cb149374379118d83c5ea619c6b93053577415 -X sigs.k8s.io/release-utils/version.gitTreeState="clean" -X sigs.k8s.io/release-utils/version.buildDate=none -o bin/controller ./cmd/controller/main.go
flag provided but not defined: -X

This quotes the LDFLAGS makefile var


          fix make build

2695f75

a-hilaly approved these changes

View reviewed changes

Member

a-hilaly left a comment

Thank you sir!

a-hilaly changed the title ~~fix make build~~ Fix make build rule

a-hilaly merged commit 16ef150 into kro-run:main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet