Improve gramar and fix errors messages in graph, metadata and runtime package #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-hilaly
reviewed
Apr 7, 2025
| @@ -550,7 +550,7 @@ func (rt *ResourceGraphDefinitionRuntime) WantToCreateResource(resourceID string | |||
| } | |||
| // returning a reason here to point out which expression is not ready yet | |||
| if !value.(bool) { | |||
| return false, fmt.Errorf("Skipping resource creation due to condition %s", condition) | |||
| return false, fmt.Errorf("skipping resource creation due to condition %s", condition) | |||
There was a problem hiding this comment.
I believe this might be breaking some unit tests, can you please change those too?
There was a problem hiding this comment.
Sure! I'll do that @a-hilaly
There was a problem hiding this comment.
@a-hilaly UT should pass now. I locally executed and it got passed.
a-hilaly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.