Skip to content

Fix infinite loop in fieldPath parser for single-letter field names #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025

Conversation

gfrey
Copy link

@gfrey gfrey commented Apr 8, 2025

Field names with just a single letter, say 'data.A' for a data field in a configmap would result in an infinite loop.

Field names with just a single letter, say 'data.A' for a data field in
a configmap would result in an infinite loop.
@a-hilaly a-hilaly changed the title Fix fieldpath parser Fix infinite loop in fieldPath parser for single-letter field names Apr 8, 2025
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! Thank you Gereon! :)

@a-hilaly a-hilaly merged commit 965cb76 into kro-run:main Apr 8, 2025
4 checks passed
@gfrey gfrey deleted the fix_fieldpath_parser branch April 8, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants