-
Notifications
You must be signed in to change notification settings - Fork 20
Feature/105767 cubic meters cargo #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: integration/API59
Are you sure you want to change the base?
Feature/105767 cubic meters cargo #311
Conversation
…me. Properties, documentation, and some tlisp is not yet updated for this. XML is definitely not updated yet (this is currently just assumes a 1:1 water-density conversion. This should be adventure configurable)
|
Turns out we also need to support an early version of armor size classes, and relevant criteria for item volumes as well. |
… of XML mass to volume, and to compute actual mass from the computed volume (This supports alternative balance system that do not make the same item/cargo density assumptions as legacy SotP
|
Also we might need to have a legacy cargo conversion system for older ships (this one can just be based on API) |
…holds to the new volume system using the same engine options for item mass to volume conversion
… the correct density
…sities, convert water items over
…m because item size is now the primary balancing factor and it makes sense to have different density armor within the same size class, add in compatibility conversions to new system, add aliased names for mass classes (so that chronicles can still support dreadnought armor properly while using its own custom name: supermassive)
…and unitless cases. Also supports NaN and infinities.
…05927-fmtNumber_metric
…05927-fmtNumber_metric
…idual ret args and hardcoded options
…05927-fmtNumber_metric
…05927-fmtNumber_metric
…y only supports Metrics, but can be expanded in the future)
…tyle syntax and @:a-b style syntax (the latter is missing from a bunch of other range types, will deal with that in a different PR)
|
I am going to tentatively switch this to using CBM (the standard name for cubic meters in the world of shipping and logistics) because of the following factors:
CBM solves ALL of these issues:
|
…ents too, add TODO warnings on tons of ore player stat code which assume SotP tons of ore items not VotG krels of ore or Chronicles ore chunks
|
In order to make formatting numbers easier, I'm just going to merge #317 into this branch - merge that PR first (it has its own PR to merge before that though) |
… into feature/105767-cubic_meters_cargo
…date and does not handle failures properly, uses strtod instead which also eliminates the need for checking for hexadecimal. Will be cherrypicked to its own branch as well.
…ng because it was redundant with the inventory UI, and not useful when the armor class string was there instead. Also updated the variable name for armor class string.
…assDesc, deprecate unidArmorMass (to be added to a compat library in the future)
Atof is horrifically out of date and does not handle failures properly, uses strtod instead which also eliminates the need for checking for hexadecimal
|
Also now includes #325 - merge that one first |
…ture/105767-cubic_meters_cargo
…g liters so compatability math continues to work
…oppy script inputs or when a player has used scripts or debugtools to overfill their cargo
|
Also contains #329 - merge that one first too |
…105927-fmtNumber_metric # Conflicts: # Mammoth/Include/TSELanguage.h # Mammoth/Include/TSEVersions.h # Mammoth/TSE/CLanguage.cpp
…bic_meters_cargo # Conflicts: # Mammoth/Include/TSEVersions.h
…105767-cubic_meters_cargo # Conflicts: # Mammoth/Include/TSEVersions.h # Mammoth/TSE/LanguageDefs.h
As of PR creation time, this contains just the foundational code for separating out item volume from item mass, and switching cargo space to actually match its name and convey volume rather than density
Mass is still used for calculating maneuverability, armor class, and stuff like that
Volume is now used for calculating cargo limits
Things to do: