Break out of typealias cycles#1446
Merged
Merged
Conversation
When there’s a typealias cycle, we currently loop infinitely and eventually consume all system memory and crash.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an infinite loop vulnerability that occurs when typealiases form a cycle (e.g., typealias Foo = Bar and typealias Bar = Foo), which previously caused the system to consume all memory and crash. The fix implements cycle detection using a visited set to track aliases during resolution and breaks out of the loop when a cycle is detected, logging a warning instead.
Key Changes:
- Added cycle detection logic in typealias resolution to prevent infinite loops
- Added test coverage for typealias cycle scenarios
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| SourceryRuntime/Sources/Common/Composer/ParserResultsComposed.swift | Implements cycle detection by tracking visited alias names in a Set and breaking the loop when a cycle is detected, with a warning log |
| SourceryTests/Parsing/ComposerSpec.swift | Adds test case to verify the system handles typealias cycles without looping infinitely |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
thanks @erichoracek |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there’s a typealias cycle, we currently loop infinitely and eventually consume all system memory and crash.